Bug 1565980
Summary: | Node condition does not update when new issue detected by node-problem-detector | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Weinan Liu <weinliu> |
Component: | Node | Assignee: | Joel Smith <joelsmith> |
Status: | CLOSED NOTABUG | QA Contact: | Weinan Liu <weinliu> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 3.10.0 | CC: | aos-bugs, dma, jchaloup, joelsmith, jokerman, mmccomas, sjenning |
Target Milestone: | --- | ||
Target Release: | 3.10.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1564852 | Environment: | |
Last Closed: | 2018-05-10 04:15:36 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Weinan Liu
2018-04-11 08:53:04 UTC
@Joel, could you help to confirm if it's an issue or invalid scenario? Joel, can you respond to this? I'm not certain, but it may be that this behavior is intended. In other words, perhaps the NPD only records the first reason and message when transitioning from false to true. I started looking through the code to see if this is the case, but didn't find it yet. I'll be out of the office this week, but I'll try to spend some time on it anyway so we can decide if this bug needs to be fixed or not. Thanks! I finally found the code responsible and it appears that this behavior is intentional. I believe that the reason for this behavior is to prevent noisy log entries from potentially causing many node updates despite the node condition not changing in a material way. If interested, here is the code and comment explaining it: https://github.com/kubernetes/node-problem-detector/blob/10dbfef1a88d9ea05fabb600d31609f9dbdf2045/pkg/systemlogmonitor/log_monitor.go#L138-L144 With this in mind, I'm closing this as NOTABUG. Thanks for your testing efforts. |