Bug 1567603

Summary: [CodeChange] Cleanup create snapshot code after requiring qemu > 2.10
Product: [oVirt] vdsm Reporter: Ala Hino <ahino>
Component: CoreAssignee: Ala Hino <ahino>
Status: CLOSED CURRENTRELEASE QA Contact: Avihai <aefrat>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.20.0CC: ahino, bugs, lveyde, ylavi
Target Milestone: ovirt-4.2.4Flags: rule-engine: ovirt-4.2+
ylavi: exception+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vdsm v4.20.29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-26 08:45:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1567806    
Bug Blocks:    

Description Ala Hino 2018-04-15 11:16:44 UTC
Description of problem:
After requiring qemu-img 2.10, we don't have to check if
prepare/teardown volumes is required. The logic of checking whether
prepare/teardown is required added in commit 7222af88 (create-snapshot:
Use unsafe option when creating snapshots), when at that time we still
used qemu-img<2.10 that didn't support unsafe operations

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Avihai 2018-06-10 11:18:56 UTC
Verified, ran sanity(Tier1) tests on fixed build 4.2.4 and tests passed.

Comment 4 Sandro Bonazzola 2018-06-26 08:45:14 UTC
This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.