Bug 156921
| Summary: | 2 * missing return expressions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> |
| Component: | rsync | Assignee: | Jay Fenlason <fenlason> |
| Status: | CLOSED RAWHIDE | QA Contact: | Mike McLean <mikem> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jfeeney |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-19 18:51:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
You should report this upstream at http://rsync.samba.org/bugzilla.html This'll give the upstream Rsync developers a chance to fix it faster than I can. The upstream file patches/acls.diff was updated to fix this back in May. |
Description of problem: I just tried to compile package rsync-2.6.4-2 from Redhat Fedora Core development tree with the most excellent Intel C compiler. The compiler said flist.c(975): warning #117: non-void function "send_file_name" should return a value flist.c(977): warning #117: non-void function "send_file_name" should return a value The source code is static struct file_struct *send_file_name(int f, struct file_list *flist, char *fname, unsigned short base_flags) { struct file_struct *file; file = make_file(fname, flist, f == -2 ? SERVER_FILTERS : ALL_FILTERS); if (!file) return NULL; if (!MAKE_ACL(file, fname)) return; if ( ! MAKE_XATTR(file, fname ) ) return; Suggest add expressions to the two return statements. Maybe NULL would do ? Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: