Bug 1570143
| Summary: | [3.9] Wildcard routes take precedence over other routes that start with a number | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Ben Bennett <bbennett> |
| Component: | Networking | Assignee: | Ram Ranganathan <ramr> |
| Networking sub component: | router | QA Contact: | Meng Bo <bmeng> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | high | ||
| Priority: | unspecified | CC: | aos-bugs, bbennett, bleanhar, bmeng, erich, mjaros, ramr, smunilla, zzhao |
| Version: | 3.6.0 | Keywords: | NeedsTestCase |
| Target Milestone: | --- | ||
| Target Release: | 3.9.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1561752 | Environment: | |
| Last Closed: | 2018-05-21 07:15:12 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1561752 | ||
| Bug Blocks: | |||
|
Description
Ben Bennett
2018-04-20 17:49:22 UTC
@ramr: Can you backport this to OSE 3.9 please. Just spoke to Ben about this right now. On the original PR set, there was some comments and a follow on PR is in the works. So rather than merge an intermediate change - will merge the changes in based on the new PR (yet-to-be-created) getting approved. The second version of the original fix in origin is: https://github.com/openshift/origin/pull/19492 waiting for that to merge (in origin) before I backport this. @Ben, just realized a back port is going to require more cherry picks than I had initially thought. The template simplification changes (for backends) were done as part of 3.10 work and the fixes for the sorting are based on those template simplification changes. Should I cherry pick those changes as well? Otherwise we will have to make changes to the sort template helper code specifically for 3.9 - which does create some divergence. Let me know how you want me to proceed on this. My 2c is to pull in the template simplification changes. Thanks. @Ram: Let's just backport the sort in bash for this... I'm getting nervous if we have to backport too much. @Ben, cool - that is definitely safer. Created a PR: https://github.com/openshift/ose/pull/1252 Note: this is the original commit + fixes specific to OSE 3.9 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:1628 *** Bug 1582875 has been marked as a duplicate of this bug. *** |