Bug 157031
| Summary: | fence packaging nits | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joe Orton <jorton> |
| Component: | fence | Assignee: | Chris Feist <cfeist> |
| Status: | CLOSED INSUFFICIENT_DATA | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | triage |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | bzcl34nup | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-07 00:10:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Is there a web/wiki page somewhere that details issues like this? I maintain ~20 packages and it would be useful to have a outline of how the .spec files are supposed to look. There is http://www.fedoraproject.org/wiki/PackagingGuidelines and there is an internal wiki page somewhere too, but they probably don't cover everything. All of these issues should be resolved in fence-1.27-16. Looks good. One further comment: Why is the init script marked as a %config file? Generally they shouldn't be; if there's no reason for a user to modify the file it shouldn't be marked %config. And it already sources sysconfig/cluster for config variables, which is the right way to allow users to control init script behaviour. Based on the date this bug was created, it appears to have been reported against rawhide during the development of a Fedora release that is no longer maintained. In order to refocus our efforts as a project we are flagging all of the open bugs for releases which are no longer maintained. If this bug remains in NEEDINFO thirty (30) days from now, we will automatically close it. If you can reproduce this bug in a maintained Fedora version (7, 8, or rawhide), please change this bug to the respective version and change the status to ASSIGNED. (If you're unable to change the bug's version or status, add a comment to the bug and someone will change it for you.) Thanks for your help, and we apologize again that we haven't handled these issues to this point. The process we're following is outlined here: http://fedoraproject.org/wiki/BugZappers/F9CleanUp We will be following the process here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this doesn't happen again. This bug has been in NEEDINFO for more than 30 days since feedback was first requested. As a result we are closing it. If you can reproduce this bug in the future against a maintained Fedora version please feel free to reopen it against that version. The process we're following is outlined here: http://fedoraproject.org/wiki/BugZappers/F9CleanUp |
1. don't own /sbin and mandir, in %files use e.g.: /sbin/* %{_mandir}/man?/* to just own the *files within those directories*, not the directories themselves. The filesystem package should be the only one to own /sbin etc. 2. use the %{ix86} macro in ExclusiveArch, not i386 3. use a blank line between each changelog entry 4. use "make %{?_smp_mflags}" if your Makefile supports parallel builds; better buildsystem utilization from SMP build boxes 5. add "Requires(post,preun): /sbin/chkconfig" for the scriptlet deps 6. more descriptive %description please! :)