Bug 1571742
Summary: | Review Request: js-viewport-navigation - Scrolling viewport contents navigation menu for web pages | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel J. R. May <daniel.may> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, per |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-06-01 12:09:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841 |
Description
Daniel J. R. May
2018-04-25 10:48:53 UTC
I have just realized that I should have used the rawhide buildroot. Here are the correctd files: Spec URL: https://copr-be.cloud.fedoraproject.org/results/danieljrmay/viewport-navigation/fedora-rawhide-x86_64/00745441-js-viewport-navigation/js-viewport-navigation.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/danieljrmay/viewport-navigation/fedora-rawhide-x86_64/00745441-js-viewport-navigation/js-viewport-navigation-0.5-1.fc29.src.rpm koji scratch build for f29: https://koji.fedoraproject.org/koji/taskinfo?taskID=26557232 Some preliminary informal comments, based on just the GitHub project. These are my personal opinions/suggestions as a Fedora user, not a Fedora packing expert. * I think you need to make a case for why this should be in Fedora. It would be helpful if you linked to some web-page that actually uses the library - i.e. some real-life non-trivial web-page (with non-trivial styling). Perhaps documentation or the home page for some other Fedora package (or proposed package). * How does your navigator deal with multiple pages? It seems it can only be useful for navigating a single-page document. This limits its usefulness. For comparison, I wrote a side-bar navigator for Kawa that handles navigation both between and within pages. For example try: https://www.gnu.org/software/kawa/Strings.html#Immutable-String-Constructors . It might be useful to combine your logic for watching scrolling into my side-bar navigator. * Using the GPL license for a JavaScript library means (I believe) that all of the JavaScript on a web page has to be released under the GPL. This may be a concern for some people, and limit take-up - and possibly its suitability for Fedora. I noted a minor glitch: https://github.com/danieljrmay/viewport-navigation/issues/3 Bottom line: I don't think js-viewport-navigation by itself is suitable as a Fedora package. However, I do have something related that I'd love someone to look at: Last year Mathieu Lirzin did a Google Summer of Code project (http://mathieu.lirzin.emi.u-bordeaux.fr/tags/texinfo/) to implement smart JavaScript navigation for GNU texinfo manuals. Here is his interface for the previously-mentioned Kawa manual: https://www.gnu.org/software/texinfo/gsoc-2017-js-example/kawa/Strings.html#Concatenation-and-replacing I would love for someone to combine Mathieu's code with your scroll-watcher and turn it into a separate library suitable for "book-style" sites (both ones generated from texinfo and otherwise). (Mathieu's code is GPLT, for what that is worth.) (In reply to Per Bothner from comment #2) > Some preliminary informal comments, based on just the GitHub project. > These are my personal opinions/suggestions as a Fedora user, not a Fedora > packing expert. First of all thank you so much for taking the time to look at this & sorry for taking so long to reply - I have been away for the last couple of weeks. > * I think you need to make a case for why this should be in Fedora. It > would be helpful if you linked to some web-page that actually uses the > library - i.e. some real-life non-trivial web-page (with non-trivial > styling). Perhaps documentation or the home page for some other Fedora > package (or proposed package). I think you are absolutely correct! As it stands this project shows a little promise but it is not mature enough yet. On reflection, my desire to submit it to Fedora must have been a flash of middle-aged over-exuberance! I'm rather glad to see that I'm still capable of a bit over-exuberance! ;-) However, I think the correct thing to do is withdraw this Fedora submission and go again when/if the software is more mature, fully-featured, documented and with real-life non-trivial examples of use in the wild. It current existence on github and COPR are appropriate for now. > * How does your navigator deal with multiple pages? It seems it can only be > useful for navigating a single-page document. This limits its usefulness. > For comparison, I wrote a side-bar navigator for Kawa that handles > navigation both between and within pages. For example try: > https://www.gnu.org/software/kawa/Strings.html#Immutable-String-Constructors > . It might be useful to combine your logic for watching scrolling into my > side-bar navigator. Correct. As it stands it is a one-page only thing. Thank you for the links I will have a look into your suggestion. > * Using the GPL license for a JavaScript library means (I believe) that all > of the JavaScript on a web page has to be released under the GPL. This may > be a concern for some people, and limit take-up - and possibly its > suitability for Fedora. I was unaware of this - a really good point! (In reply to Per Bothner from comment #3) > I noted a minor glitch: > https://github.com/danieljrmay/viewport-navigation/issues/3 Thank you for submitting the bug report. I'll have a look into this. (In reply to Per Bothner from comment #4) > Bottom line: I don't think js-viewport-navigation by itself is suitable as a > Fedora package. However, I do have something related that I'd love someone > to look at: Last year Mathieu Lirzin did a Google Summer of Code project > (http://mathieu.lirzin.emi.u-bordeaux.fr/tags/texinfo/) to implement smart > JavaScript navigation for GNU texinfo manuals. Here is his interface for > the previously-mentioned Kawa manual: > https://www.gnu.org/software/texinfo/gsoc-2017-js-example/kawa/Strings. > html#Concatenation-and-replacing > > I would love for someone to combine Mathieu's code with your scroll-watcher > and turn it into a separate library suitable for "book-style" sites (both > ones generated from texinfo and otherwise). (Mathieu's code is GPLT, for > what that is worth.) Sounds interesting. I will have a look into this. Following the excellent points raised by Per Bothner I am marking this CLOSED-DEFERRED as js-viewport-navigation is not mature enough yet for inclusion in Fedora. |