Bug 1571784
| Summary: | rstrnt-report-result is incompatible with beakerlib but set as command for reporting result | ||
|---|---|---|---|
| Product: | [Retired] Restraint | Reporter: | Pavel Holica <pholica> |
| Component: | general | Assignee: | Matt Tyson 🤬 <mtyson> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jacob McKenzie <jmckenzi> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | asavkov, azelinka, bpeck, dcallagh, jmckenzi, mtyson, vdanek |
| Target Milestone: | 0.1.35 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-06-24 23:49:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The problem is, that beakerlib does: rstrnt-report-result "$testname" "$result" "$logfile" "$score" but restraint expects: rstrnt-report-result TASK_PATH RESULT SCORE The workaround is to put following line to the test itself: export BEAKERLIB_COMMAND_REPORT_RESULT=/usr/bin/rhts-report-result Sorry about not mentioning that the workaround requires to have restraint-rhts installed. This is actually preventing the beaker dogfood test suite from being run using restraint, but fixing it is a little more involved than I initially thought. I've modified rstrnt-report-result to have two argument parsing frontends. One is the rstrnt-report-result style, the other is compatible with the old rhts-report-result style. In the restraint RPM package there will be: /usr/bin/rhts-report-result /usr/bin/rstrnt-report-result Under the hood they are the same binary. It will detect the filename it was invoked as and process arguments accordingly. The beakerlib plugin will call rhts-report-result as that is the argument format it is expecting. After running a job through restraint's client using beakerlib, this bug seems to be fixed. The 'index.html' has both a score number and custom log files. |
Description of problem: In file plugins/task_run.d/15_beakerlib there's: export BEAKERLIB_COMMAND_REPORT_RESULT=/usr/bin/rstrnt-report-result In beakerlib project in file /usr/share/beakerlib/testing.sh there's: rlReport() { local testname="$1" local result="$(echo "$2" | tr '[:lower:]' '[:upper:]')" local score="$3" local logfile=${4:-$OUTPUTFILE} ... # report the result only if TESTID is set if [ -n "$TESTID" ] ; then $BEAKERLIB_COMMAND_REPORT_RESULT "$testname" "$result" "$logfile" "$score" \ || rlLogError "rlReport: Failed to report the result" fi } But rstrnt-report-result accepts different arguments: rstrnt-report-result [OPTION...] TASK_PATH RESULT SCORE ... -o, --outputfile=FILE ... rhts-report-result from restraint-rhts solves this, but even if it's installed, it's not used by default. Version-Release number of selected component (if applicable): restraint-0.1.32-1 beakerlib-1.17-6 How reproducible: always Steps to Reproduce: 1. run test using beakerlib via restraint client 2. check index.html in the result directory Actual results: Instead of score, there's path to file, desired custom logfile is never uploaded. Expected results: Correct score is shown, custom logfile is uploaded. Additional info: