Bug 1572214

Summary: no check is performed while taging of nodes and devices in heketi
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Nitin Goyal <nigoyal>
Component: heketiAssignee: Michael Adam <madam>
Status: CLOSED NOTABUG QA Contact: Nitin Goyal <nigoyal>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.3CC: hchiramm, jmulligan, rhs-bugs, sankarshan, storage-qa-internal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-07 14:39:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1568862    
Attachments:
Description Flags
output of node info with tags none

Description Nitin Goyal 2018-04-26 12:30:05 UTC
Created attachment 1427191 [details]
output of node info with tags

Description of problem: heketi is taking wrong flags, There is no check is performed while giving tags


Version-Release number of selected component (if applicable): 6.0.0-11


How reproducible: 


Steps to Reproduce:
1. run command -> $ heketi-cli node rmtags 20a87aa39c95f59c4e2083600c42ae05 arniter:disabled

Actual results: It is taking arniter.


Expected results: It should not tahe arniter.

Comment 2 Nitin Goyal 2018-05-02 12:29:37 UTC
Please run this instead of the first one which i mentioned in Steps to Reproduce
# heketi-cli node settags 20a87aa39c95f59c4e2083600c42ae05 arniter:disabled

Comment 3 John Mulligan 2018-05-07 14:39:17 UTC
Hi, if you look at the upstream docs[1] of the tagging commands it is designed to take freeform values. So "arniter" is a valid, if useless, value. 

1: https://github.com/heketi/heketi/blob/master/docs/man/heketi-cli.8

If you think its worth it, please file a RFE for new options that verify the tag keys are special known values.