Bug 1572603

Description of problem:
After upgrade from ocata to pike (dockerized) with HA controllers, we noticed cinder was no longer functional. Operations like creating new volumes from old volumes, or deleting old volumes was stuck in Deleting and creating status. 

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-7.0.12-0.20180402201322.e8b34d6.el7.centos.noarch

How reproducible:
Replace puppet-pacemaker.yaml env file by docker-ha.yaml envfile for upgrading you overcloud with HA controllers from Ocata to Pike. 


Steps to Reproduce:
Using an overcloud deploy command with the following environment files:
overcloud deploy --templates --libvirt-type kvm  --timeout 90 \
-e /home/stack/templates/node-info.yaml \
-e /home/stack/templates/network-environment-bonding.yaml \
-e /home/stack/templates/storage-environnement.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml \
-e /home/stack/templates/docker_registry.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker-ha.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/major-upgrade-composable-steps-docker.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/services-docker/ironic.yaml \
-e /home/stack/templates/ironic_env.yaml

Actual results:
Only cinder services are not containerized after the upgrade and cinder operations are stuck while deleting or cloning old volumes (existing volumes before the upgrade)


Expected results:
cinder was containerized and work as expected


Additional info:
After analyze, we found 2 things:
 - the 'host' parameter in cinder.conf is unconfigured 
 - the cinder-volume is still managed by pacemaker but active on all controllers  instead of active on one of them and passive on the others.

this trouble seems to be related with the difference between docker-ha.yaml and puppet-pacemaker.yaml. 

$ grep cinder-volume /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml
  OS::TripleO::Services::CinderVolume: ../puppet/services/pacemaker/cinder-volume.yaml
$ grep cinder-volume /usr/share/openstack-tripleo-heat-templates/environments/docker-ha.yaml
  # OS::TripleO::Services::CinderVolume: ../docker/services/pacemaker/cinder-volume.yaml

the cinder-volume services configuration is commented in docker-ha.yaml.
With Ocata we used puppet-pacemaker.yaml env file but with Pike upgrade the tripleO documentation says:
"If the Overcloud has been deployed with Pacemaker, then add the docker-ha.yaml environment file to the upgrade command".