Bug 1572654

Summary:	[DOCS] 'patch' verb missing in granting users daemonset permissions section
Product:	OpenShift Container Platform	Reporter:	David Caldwell <dcaldwel>
Component:	Documentation	Assignee:	Kathryn Alexander <kalexand>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Chuan Yu <chuyu>
Severity:	unspecified	Docs Contact:	Vikram Goyal <vigoyal>
Priority:	unspecified
Version:	3.7.0	CC:	aos-bugs, chuyu, dcaldwel, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-01 19:51:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Caldwell 2018-04-27 14:10:36 UTC

Document URL: 
https://docs.openshift.com/container-platform/3.7/admin_guide/manage_rbac.html#admin-guide-granting-users-daemonset-permissions

and

https://docs.openshift.com/container-platform/3.9/admin_guide/manage_rbac.html#admin-guide-granting-users-daemonset-permissions

Section Number and Name: 
Cluster Administration/Managing Role-based Access Control (RBAC)/Granting Users Daemonset Permissions

Describe the issue: 
The cluster role example is missing the verb 'patch'. Without patch, the user will not be able to successfully do 'oc edit daemonset' which presumably is the intended way of editing the daemonsets.

Suggestions for improvement: 

<code>
oc create clusterrole daemonset-admin --verb=create,delete,get,list,update,watch --resource=daemonsets.extensions
</code>

Should be:

<code>
oc create clusterrole daemonset-admin --verb=create,delete,get,list,update,watch,patch --resource=daemonsets.extensions
</code>

Also, it would be nice if this section contained a third step that showed the full oc edit daemonset command. Eg:

<code>
oc edit daemonset <daemonset_name>
</code>

Additional information:

Comment 1 Kathryn Alexander 2018-05-29 17:05:01 UTC

This section was removed from 3.9, so it applies to only 3.7.

Comment 3 Kathryn Alexander 2018-05-31 15:51:58 UTC

David and I had a chat over email, and I understand the request for `oc edit daemonset <daemonset_name>`.

@Chuan Yu, I have a few questions.

1) Do you think that it's appropriate to add `oc edit daemonset <daemonset_name>` to https://docs.openshift.com/container-platform/3.7/dev_guide/daemonsets.html? That topic makes it sound like you'd need to edit the daemonset, delete the existing pods/nodes, and make new ones to apply the change.

2) Does the change on this PR look good to you: https://github.com/openshift/openshift-docs/pull/9701

Comment 4 Chuan Yu 2018-06-01 02:22:36 UTC

1) Yes, add and patch should be same operation to the resource, leave the patch here is OK.

2) The changes LGTM.

Comment 5 Kathryn Alexander 2018-06-01 12:34:56 UTC

Thank you very much! I merged the change and am waiting for it to go live.

Comment 6 Kathryn Alexander 2018-06-01 19:51:58 UTC

This change is live on docs.openshift: https://docs.openshift.com/container-platform/3.7/admin_guide/manage_rbac.html#admin-guide-granting-users-daemonset-permissions

And on the portal: https://access.redhat.com/documentation/en-us/openshift_container_platform/3.7/html-single/cluster_administration/#admin-guide-granting-users-daemonset-permissions