Bug 1573092

Summary: SIGARBT when using astyle with --recursive
Product: [Fedora] Fedora Reporter: Andrew Hutchings <andrew>
Component: astyleAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: andrew, fedora, mtasaka, tomspur
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-23 23:56:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposal patch none

Description Andrew Hutchings 2018-04-30 07:54:16 UTC 
Description of problem:
astyle with SIGABRT in Fedora 28 when --recursive is used. Works fine in Fedora 27.

Version-Release number of selected component (if applicable):
astyle-3.1-3.fc28.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Go to a directory with some .c and .h files
2. Execute: astyle --recursive "*.c" "*.h"

Actual results:
Directory  /home/linuxjedi/Programming/Git/libattachsql/*.c
/usr/include/c++/8/bits/stl_vector.h:932: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = std::__cxx11::basic_string<char>; _Alloc = std::allocator<std::__cxx11::basic_string<char> >; std::vector<_Tp, _Alloc>::reference = std::__cxx11::basic_string<char>&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.
Aborted (core dumped)

Expected results:
No crash

Additional info:
As a workaround I downgraded to astyle-3.0.1-4.fc27.x86_64 which works fine.
Comment 1 Mamoru TASAKA 2018-04-30 09:12:16 UTC 
*** Bug 1573093 has been marked as a duplicate of this bug. ***
Comment 2 Mamoru TASAKA 2018-05-02 09:04:28 UTC 
Would you check if the following works?
https://koji.fedoraproject.org/koji/taskinfo?taskID=26721555
Comment 3 Andrew Hutchings 2018-05-02 10:18:51 UTC 
That works perfectly! Many thanks!
Comment 4 Mamoru TASAKA 2018-05-02 14:56:08 UTC 
Created attachment 1430099 [details]
Proposal patch

Reported upstream: https://sourceforge.net/p/astyle/bugs/503/.

Proposal patch also attached here.
Comment 5 Mamoru TASAKA 2018-05-14 04:44:20 UTC 
For now, I will take care of this.
Comment 6 Fedora Update System 2018-05-14 05:16:12 UTC 
astyle-3.1-5.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e41ea65d96
Comment 7 Fedora Update System 2018-05-14 20:39:08 UTC 
astyle-3.1-5.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e41ea65d96
Comment 8 Fedora Update System 2018-05-23 15:39:01 UTC 
astyle-3.1-5.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
Comment 9 Mamoru TASAKA 2018-05-23 23:56:52 UTC 
Fixed.