Bug 1573428
| Summary: | [DOCS] Update BuildOverrides overview | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Juan Luis de Sousa-Valadas <jdesousa> |
| Component: | Documentation | Assignee: | Michael Burke <mburke> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Wenjing Zheng <wzheng> |
| Severity: | low | Docs Contact: | Vikram Goyal <vigoyal> |
| Priority: | low | ||
| Version: | 3.9.0 | CC: | aos-bugs, jdesousa, jokerman, mmccomas |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-05-21 13:40:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Juan Luis de Sousa-Valadas
2018-05-01 08:40:04 UTC
Juan -- What do we need to fix here?
I added links to the "Manually Setting Global Build Overrides" with the values that can be used for overrides. Also, I added the conclusions that Nicolas added to the customer case. What else can we do to clarify this topic?
Further down you say:
'Regarding BuildDefaults[2] our docs say: "Build pods will only run on nodes with the key1=value2 and key2=value2 labels. Users can define a different set of nodeSelectors for their builds in which case these values will be ignored." This has to be fixed.'
How can this be improved/corrected?
The customer, Per, asked about the following:
"Defaults will only be applied if the build configuration does not define any key/value pairs for the nodeSelector and also does not define an explicitly empty map value of nodeSelector:{}." from https://docs.openshift.com/container-platform/3.9/dev_guide/builds/advanced_build_operations.html#dev-guide-assigning-builds-to-nodes. What happend when the nodeSelector is null?
Would it make sense to add Nicolas' conclusions to this section also?
PS. I saw in our docs:
Regarding BuildOverrides[1] our docs say: "Build pods will only run on nodes with the key1=value2 and key2=value2 labels" in both topics.
Should this be "key1=value1" to match the examples in both topics?
For example, <9> in Step 1
https://docs.openshift.com/container-platform/3.9/install_config/build_defaults_overrides.html#manually-setting-global-build-defaults
<1> in
https://docs.openshift.com/container-platform/3.9/dev_guide/builds/advanced_build_operations.html#dev-guide-assigning-builds-to-nodes
Juan -- How many versions back should the changes be applied? The BuildDefaults and BuildOverrides plug-ins go back to at least 3.2 Michael -- The changes look good to me. About how many branches should get this, based on the documentation available, I'm certain until 3.6. |