Bug 1573755
| Summary: | RPM installed pip should not recommend to pip install -U pip | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | python-pip | Assignee: | Miro Hrončok <mhroncok> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bkabrda, cstratak, metherid, ncoghlan, tflink, TicoTimo, torsava |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-pip-9.0.3-2.fc28 python-pip-9.0.3-2.fc27 python-pip-9.0.3-2.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-05-09 21:25:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miro Hrončok
2018-05-02 08:10:52 UTC
Is the recommendation here about the message shown only, or also the capability to update pip through pip as well? I would prefer to resolve both of those cases. This bugzilla is about the message only. Currently the python3-pip package leaves the INSTALLER file in the Python package metadata alone, so it still reports itself as being installed by `pip`: $ cat /usr/lib/python3.6/site-packages/pip-9.0.3.dist-info/INSTALLER pip (I ran "sudo dnf reinstall python3-pip" right before checking that, so it should definitely be the as-packaged file) If that was fixed to say "rpm" for the system managed version, then instead of checking for venv-or-not, the patched message generation could check for installed-by-pip-or-not. As per the discussion in https://github.com/pypa/pip/issues/5346#issuecomment-385231760, such a patch would actually be acceptable upstream, so Fedora would only need to carry the downstream patch for older pip versions. We'd also need our rewheel patch to change the installer back to pip I guess to make this work in venv. $ cat /usr/lib/python3.6/site-packages/pip-9.0.3.dist-info/INSTALLER pip $ echo rpm | sudo tee /usr/lib/python3.6/site-packages/pip-9.0.3.dist-info/INSTALLER rpm $ cat /usr/lib/python3.6/site-packages/pip-9.0.3.dist-info/INSTALLER rpm $ python3 -m venv testvenv $ cat testvenv/lib/python3.6/site-packages/pip-9.0.3.dist-info/INSTALLER pip I.e. no rewheel patch needed, yay! https://src.fedoraproject.org/rpms/python-pip/pull-request/5 Nick, could you please review this approach? I think it's bulletproof, but I might have missed something. python-pip-9.0.3-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7146cb4e7f python-pip-9.0.3-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-7146cb4e7f python-pip-9.0.3-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b795b92cc0 python-pip-9.0.3-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcbef2ab8c python-pip-9.0.3-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b795b92cc0 python-pip-9.0.3-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcbef2ab8c python-pip-9.0.3-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. python-pip-9.0.3-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. python-pip-9.0.3-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |