Bug 1574191
| Summary: | SyncNetworkProviderCommand fails on NPE if Provider is DNP of a Cluster with no DC | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Elad <ebenahar> | ||||
| Component: | BLL.Network | Assignee: | Dominik Holler <dholler> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Michael Burman <mburman> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | future | CC: | bugs, dholler, mburman | ||||
| Target Milestone: | ovirt-4.2.4 | Flags: | rule-engine:
ovirt-4.2+
|
||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ovirt-engine-4.2.4 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Cause: If there is a cluster without a data center, but with a default network provider, network synchronization of the provider fails.
Consequence: Automatic network synchronization fails.
Fix: Clusters without a data center are skipped during network synchronization.
Result: Automatic network synchronization does not fails,
if there is a cluster without a data center, but with a default network provider.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-06-26 08:45:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
I don't see this on my environments Hi Elad, would you share please the output of sudo su - postgres -c "psql -U postgres engine -c 'select cluster_id,name,storage_pool_id,default_network_provider_id from cluster;'" sudo su - postgres -c "psql -U postgres engine -c 'select id,name,provider_type,auto_sync from providers;'" Thanks [root@storage-ge-02 ~]# sudo su - postgres -c "psql -U postgres engine -c 'select cluster_id,name,storage_pool_id,default_network_provider_id from cluster;'"
cluster_id | name | storage_pool_id | default_network_provider_id
--------------------------------------+--------------------+--------------------------------------+--------------------------------------
8d6ffbb0-e975-4ace-adc3-def0af5ce972 | golden_env_mixed_2 | 49c00996-950e-46e0-af83-e76fcb8b2184 |
05d68095-9e6c-4661-bdf3-dfb945a2bf5c | golden_env_mixed_1 | 49c00996-950e-46e0-af83-e76fcb8b2184 |
12597888-4ae1-11e8-a876-001a4a16972d | Default | | 4f5111ff-99a4-40fa-a164-84c9c7b7b6cf
(3 rows)
Thanks, the problem is that the cluster default has no storage_pool_id / data center. From my point of view, this should be not allowed, but the db allows this. I will do some research on this. It is allowed for clusters to have no data center, so SyncNetworkProviderCommand should handle this. Dominik, can you please update then the summary of this report? Verified on - 4.2.4-0.1.el7 This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1430253 [details] engine and server logs Description of problem: SyncNetworkProviderCommand fails on NPE for the default ovirt-provider-ovn external network provider Version-Release number of selected component (if applicable): rhvm-4.2.3.3-0.1.el7.noarch How reproducible: Always Steps to Reproduce: 1. Have a RHV setup with the default ovirt-provider-ovn external network provider Actual results: Every 5 minutes: 2018-05-02 21:43:49,997+03 INFO [org.ovirt.engine.core.bll.provider.network.SyncNetworkProviderCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-56) [41a075c4] Lock Acquired to object 'EngineLock:{exclus iveLocks='[4f5111ff-99a4-40fa-a164-84c9c7b7b6cf=PROVIDER]', sharedLocks=''}' 2018-05-02 21:43:50,018+03 INFO [org.ovirt.engine.core.bll.provider.network.SyncNetworkProviderCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-56) [41a075c4] Running command: SyncNetworkProviderCommand internal: true. 2018-05-02 21:43:50,252+03 INFO [org.ovirt.engine.core.sso.utils.AuthenticationUtils] (default task-11) [] User admin@internal successfully logged in with scopes: ovirt-app-api ovirt-ext=token-info:authz-search ovirt-ext=token-info:public-authz-search ovirt-ext=token-info:validate ovirt-ext=token:password-access 2018-05-02 21:43:50,511+03 ERROR [org.ovirt.engine.core.bll.provider.network.SyncNetworkProviderCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-56) [41a075c4] Command 'org.ovirt.engine.core.bll.provider .network.SyncNetworkProviderCommand' failed: null 2018-05-02 21:43:50,511+03 ERROR [org.ovirt.engine.core.bll.provider.network.SyncNetworkProviderCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-56) [41a075c4] Exception: java.lang.NullPointerException at org.ovirt.engine.core.bll.provider.network.SyncNetworkProviderCommand.lambda$executeCommand$3(SyncNetworkProviderCommand.java:152) [bll.jar:] at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) [rt.jar:1.8.0_161] at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382) [rt.jar:1.8.0_161] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) [rt.jar:1.8.0_161] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) [rt.jar:1.8.0_161] at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708) [rt.jar:1.8.0_161] at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) [rt.jar:1.8.0_161] at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499) [rt.jar:1.8.0_161] at org.ovirt.engine.core.bll.provider.network.SyncNetworkProviderCommand.executeCommand(SyncNetworkProviderCommand.java:154) [bll.jar:] Additional info: engine and server logs attached, please ask for more info if needed.