Bug 1574684

Summary: ConnectionPool should not lowercase all hostnames
Product: [Fedora] Fedora Reporter: Lukas Slebodnik <lslebodn>
Component: python-urllib3Assignee: Fedora Infrastructure SIG <infra-sig>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: aurelien, infra-sig, jcline, jeremy
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-urllib3-1.22-6.fc27 python-urllib3-1.20-3.fc26 python-urllib3-1.22-9.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-15 19:52:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lukas Slebodnik 2018-05-03 20:35:42 UTC
Description of problehtm:
There are lowercase hostnames with custom-protocol e.g. (http+unix)
which is used for HTTP communication via unix sockets.

Lowercaed hostnames are not the problem with DNS but filenames are case sensitive.

Version-Release number of selected component (if applicable):
python-urllib3-1.20-2.fc26

How reproducible:
Deterministic

Additional info:
You can see more details in upstream ticket and pull-request
https://github.com/urllib3/urllib3/issues/1267
https://github.com/urllib3/urllib3/pull/1361

Issue is not present in unsupported fedora 25 because it was introduced in upstream 1.20. (and it took me some time to provide patch to upstream)
But it would be good to have f26 fixed before EOL and it is not clear wnen will be next upstream release,

Please consider this BZ as a tracker of backport for trivial upstream fix which also contains unit-test.

Comment 1 Lukas Slebodnik 2018-05-03 20:40:19 UTC
I created PR for rawhide
https://src.fedoraproject.org/rpms/python-urllib3/pull-request/3
and it should be trivial to backport if to f26+

Comment 2 Jeremy Cline 2018-05-04 14:18:35 UTC
Hi Lukas,

I've cherry-picked this as far back as F27, but it doesn't apply cleanly to F26 since it's 1.20. Do you need it to land in F26 (EOL next month) or is back through 27 acceptable?

Comment 3 Lukas Slebodnik 2018-05-05 09:38:20 UTC
(In reply to Jeremy Cline from comment #2)
> Hi Lukas,
> 
> I've cherry-picked this as far back as F27, but it doesn't apply cleanly to
> F26 since it's 1.20. Do you need it to land in F26 (EOL next month) or is
> back through 27 acceptable?

I created a PR for f26 branch. (it is indeed a little bit more complicated then cherry-pick)
https://src.fedoraproject.org/rpms/python-urllib3/pull-request/5

Thank you very much for fast response.

Comment 4 Fedora Update System 2018-05-05 21:28:51 UTC
python-urllib3-1.22-6.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-abae82adfd

Comment 5 Fedora Update System 2018-05-05 21:29:02 UTC
python-urllib3-1.22-9.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-94c21a07dc

Comment 6 Fedora Update System 2018-05-06 23:42:36 UTC
python-urllib3-1.22-6.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-abae82adfd

Comment 7 Fedora Update System 2018-05-07 10:47:30 UTC
python-urllib3-1.22-9.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-94c21a07dc

Comment 8 Fedora Update System 2018-05-07 17:58:43 UTC
python-urllib3-1.20-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d567575dd

Comment 9 Fedora Update System 2018-05-09 22:27:35 UTC
python-urllib3-1.20-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d567575dd

Comment 10 Fedora Update System 2018-05-15 19:52:55 UTC
python-urllib3-1.22-6.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-05-15 20:00:30 UTC
python-urllib3-1.20-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2018-05-15 20:05:38 UTC
python-urllib3-1.22-9.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.