Bug 1575076

Summary:	Template import from git, always adds newline
Product:	Red Hat Satellite	Reporter:	Onkar <omankame>
Component:	Provisioning Templates	Assignee:	Marek Hulan <mhulan>
Status:	CLOSED ERRATA	QA Contact:	Silvie Chlupova <schlupov>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.3.0	CC:	aagrawal, adujicek, egolov, jhutar, mhulan, oprazak, schlupov
Target Milestone:	6.4.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-1.18.0.24-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-16 19:03:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Onkar 2018-05-04 17:08:47 UTC

Description of problem: Every time do an import of the templates, it adds a newline to certain scripts.


Version-Release number of selected component (if applicable):
Satellite 6.3.0


How reproducible:
Configure Template sync in the satellite. Then configure GitHub link.
Export templates. Made some changes in templates. Export templates in satellite.
Now every next import and export add in new line in template.




Steps to Reproduce:
1.
2.
3.

Actual results: New line getting added in templates.


Expected results: New lines should be added in templates.


Additional info:

Comment 5 Ondřej Pražák 2018-06-12 11:12:43 UTC

I could not reproduce with 6.4, it seems like this issue could be fixed as a part of previous changes targeted for 6.4. Could QE verify if this is still present on 6.4?

Comment 7 Marek Hulan 2018-08-21 14:52:02 UTC

This seems to happen only for specific template. The subject is misleading, this actually happens on export and only if template has "shebang", e.g. the bootdisk template.

it's a oneliner fix in foreman core. It would be reproducible via export/import API too

Comment 8 Marek Hulan 2018-08-21 14:53:16 UTC

Created redmine issue https://projects.theforeman.org/issues/24672 from this bug

Comment 9 Satellite Program 2018-08-21 16:14:51 UTC

Upstream bug assigned to mhulan

Comment 10 Satellite Program 2018-08-21 16:14:54 UTC

Upstream bug assigned to mhulan

Comment 14 Bryan Kearney 2018-10-16 19:03:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927