Bug 1575077
Summary: | Deleting a recently shutdown appliance silently fails | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Tasos Papaioannou <tpapaioa> |
Component: | UI - OPS | Assignee: | Zita Nemeckova <znemecko> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Tasos Papaioannou <tpapaioa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 5.9.0 | CC: | abellott, cpelland, hkataria, jrafanie, lavenel, mpovolny, obarenbo |
Target Milestone: | GA | ||
Target Release: | cfme-future | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-06-11 15:26:59 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tasos Papaioannou
2018-05-04 17:09:10 UTC
After the server has been unresponsive for more than 10 minutes, the server record can be deleted successfully, but the Diagnostics accordion does not get updated. Clicking on the now-deleted server from the Diagnostics accordion leads to a flash error message: "Last selected Server no longer exists" This PR will fix the backend validation: https://github.com/ManageIQ/manageiq/pull/17391 This will not fix the UI interaction described in the BZ though. The UI code will need to attempt to destroy the server record and check the server.errors for any error messages. Reassigning to the UI team... 1) I was able to boot with rails s, make sure my server was created 2) remove my GUID file and bin/rails s again, make sure my server showed up in the Diagnostics tab as a second server. 3) I then modified my original server, id 1 in rails console: s = MiqServer.find(1) s.update(:last_heartbeat => 5.minutes.ago, :status => "stopped", :is_master => false) 4) I then rails s and attempted to delete my first server in diagnostics (servers) screen and was now able to (it wasn't grayed out) but it silently did nothing. I see this in my rails log (dev mode): F, [2018-05-07T15:52:08.026505 #94864] FATAL -- : Error caught: [ActionView::MissingTemplate] Missing partial ops/_tree, application/_tree with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :haml, :rjs]}. Searched in: * "/Users/joerafaniello/.gem/ruby/2.4.4/bundler/gems/miq_v2v_ui_plugin-f45e51c1e266/app/views" * "/Users/joerafaniello/.gem/ruby/2.4.4/bundler/gems/manageiq-ui-classic-56248224ca5a/app/views" The UI code will need to attempt to destroy the record and then check the errors for any failure messages as shown in my unit tests. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/7040201ebe5f1d39f01d9eec7a5647c09fb4a94f commit 7040201ebe5f1d39f01d9eec7a5647c09fb4a94f Author: Joe Rafaniello <jrafanie> AuthorDate: Mon May 7 12:20:18 2018 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Mon May 7 12:20:18 2018 -0400 Fix current/active server deletability validation https://bugzilla.redhat.com/show_bug.cgi?id=1575077 Note, the UI will need to check server.errors after attempting to destroy the record to see any errors. app/models/miq_server.rb | 11 +- spec/models/miq_server_spec.rb | 17 + 2 files changed, 24 insertions(+), 4 deletions(-) No, this BZ is half done. The backend now stores the validation error and the UI will have to check for errors and display them. |