Bug 1575520

This seems to be addressed upstream:
https://github.com/lvc/abi-compliance-checker/commit/bcc9a7679a772135260cf1921e6c7fe7fc10d3c2

I'll try to keep an eye out for the new release but feel free to let me know if you see it first.

Why not backport this specific patch? Without it abi-compliance-checker is broken in fedora28.

Since he's already committed the change in version I assume the new release will happen very soon. If not, I'll make a patch from the commit.

I noticed the commit was over a month ago so I have emailed the author to see if the lack of release was intentional or not.

Ok, the commit does not apply cleanly and appears to be dependent on other commits. If you want to create a clean patch I'll review it, otherwise I'm going to wait on the 2.3 release.

Created attachment 1433613 [details]
gcc8 compatibility for abi-compliance-checker

I rebased the patch but don't use abi-compliance-checker. Can someone check that this fixes the issue?

Here's a test package based on the patch, please confirm it fixes the problem. When I get a second I'll check that it still works on my F27 system w/ GCC 7.

https://kojipkgs.fedoraproject.org//work/tasks/6903/26856903/abi-compliance-checker-2.2-3.fc29.noarch.rpm

It works for me minus the dependency issue on findutils (reported separately). May I suggest the following sanity check (as CI/Test https://fedoraproject.org/wiki/CI/Tests ), if there is no other testsuite for that?


cat >c.c <<_EOF_
#include <stdio.h>

int apicall(int a)
{
printf("hello world %d\n", a);
return 0;
}
_EOF_

$ mkdir -p api-ok
$ mkdir -p api-broken

cat >api-ok/c.h <<_EOF_

int apicall(int a);
_EOF_

cat >api-broken/c.h <<_EOF_

int apicall(int a, void *ptr);
_EOF_


$ gcc -g -c -Wall -Werror -fpic c.c
$ gcc -shared -o libfoo.so c.o
$ cp libfoo.so api-ok/
$ cp libfoo.so api-broken/
$ abi-dumper libfoo.so

$ abi-compliance-checker -l foo -old api-ok -new ABI.dump # ok
$ abi-compliance-checker -l foo -old api-broken -new ABI.dump # fails

I'll consider adding a test in the future but it's not something I've done before and don't have the spare cycles right now to figure it out.

abi-compliance-checker-2.2-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a727930b7f

abi-compliance-checker-2.2-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8de33c103f

abi-compliance-checker-2.2-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-1171f003c1

abi-compliance-checker-2.2-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a727930b7f

abi-compliance-checker-2.2-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8de33c103f

abi-compliance-checker-2.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-1171f003c1

abi-compliance-checker-2.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f38c8d8188

abi-compliance-checker-2.3-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b68f0ba2c0

abi-compliance-checker-2.3-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-21e393fe5c

abi-compliance-checker-2.3-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-21e393fe5c

abi-compliance-checker-2.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-b68f0ba2c0

abi-compliance-checker-2.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f38c8d8188

abi-compliance-checker-2.3-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

abi-compliance-checker-2.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

abi-compliance-checker-2.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.