Bug 1575901

Summary:	Fluentd daemonset nodeSelector from deployment (facts) is replaced by inventory deployment nodeSelector
Product:	OpenShift Container Platform	Reporter:	Junqi Zhao <juzhao>
Component:	Logging	Assignee:	ewolinet
Status:	CLOSED ERRATA	QA Contact:	Junqi Zhao <juzhao>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.9.0	CC:	aos-bugs, ewolinet, jcantril, juzhao, rmeggins
Target Milestone:	---
Target Release:	3.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-07-30 19:14:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Junqi Zhao 2018-05-08 08:48:32 UTC

Description of problem:
This defect is split from https://bugzilla.redhat.com/show_bug.cgi?id=1561196#c15

Deploy logging firstly and change fluentd nodeSelector to non-default value, logging-infra-test-fluentd=true

# oc get ds
NAME              DESIRED   CURRENT   READY     UP-TO-DATE   AVAILABLE   NODE SELECTOR                     AGE
logging-fluentd   2         2         2         2            2           logging-infra-test-fluentd=true   10m

Update logging with the same inventory, fluentd nodeSelector would always use the default nodeSelector logging-infra-fluentd=true, not get the existing nodeSelector from environment

# oc get ds
NAME              DESIRED   CURRENT   READY     UP-TO-DATE   AVAILABLE   NODE SELECTOR                AGE
logging-fluentd   2         2         2         2            2           logging-infra-fluentd=true   15m

Version-Release number of selected component (if applicable):
# rpm -qa | grep openshift-ansible
openshift-ansible-roles-3.9.27-1.git.0.52e35b5.el7.noarch
openshift-ansible-docs-3.9.27-1.git.0.52e35b5.el7.noarch
openshift-ansible-playbooks-3.9.27-1.git.0.52e35b5.el7.noarch
openshift-ansible-3.9.27-1.git.0.52e35b5.el7.noarch


How reproducible:
Always

Steps to Reproduce:
1. See the description part
2.
3.

Actual results:
Always use 

Expected results:
Should use existing fluentd nodeSelector

Additional info:

Comment 1 ewolinet 2018-05-10 20:03:02 UTC

https://github.com/openshift/openshift-ansible/pull/8335

Comment 5 Junqi Zhao 2018-05-16 05:21:07 UTC

Tested with openshift-ansible-3.10.0-0.47.0.git.0.c018c8f.el7.noarch
existing nodeselectors for fluentd could be used when update logging

Comment 7 errata-xmlrpc 2018-07-30 19:14:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1816