Bug 1575910

Summary: DHT Log flooding in mount log "key=trusted.glusterfs.dht.mds [Invalid argument]"
Product: [Community] GlusterFS Reporter: Mohit Agrawal <moagrawa>
Component: distributeAssignee: Mohit Agrawal <moagrawa>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: bugs, ksandha, nbalacha, rhs-bugs, sankarshan, sheggodu, storage-qa-internal, tdesala
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1575895 Environment:
Last Closed: 2018-10-23 15:07:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1575895, 1579755, 1579757    
Bug Blocks:    

Comment 1 Worker Ant 2018-05-08 09:44:55 UTC
REVIEW: https://review.gluster.org/19981 (dht: Avoid dict log flooding for internal MDS xattr) posted (#1) for review on master by MOHIT AGRAWAL

Comment 2 Worker Ant 2018-05-08 15:51:25 UTC
COMMIT: https://review.gluster.org/19981 committed in master by "MOHIT AGRAWAL" <moagrawa> with a commit message- dht: Avoid dict log flooding for internal MDS xattr

Problem: Before populate MDS internal xattr first dht checks if MDS is
         present in xattr or not.If xattr dictionary is NULL dict_get
         log the message either dict or key is NULL

Solution: Before call dict_get check xattr, if it is NULL then no
          need to call dict_get.

BUG: 1575910
Change-Id: I81604ec5945b85eba14b42f4583d06ec713028f4
fixes: bz#1575910
Signed-off-by: Mohit Agrawal <moagrawa>

Comment 3 Worker Ant 2018-05-21 03:31:34 UTC
REVIEW: https://review.gluster.org/20040 (dht: Avoid dict log flooding for internal MDS xattr) posted (#1) for review on release-4.1 by MOHIT AGRAWAL

Comment 4 Worker Ant 2018-05-22 04:53:58 UTC
REVISION POSTED: https://review.gluster.org/20040 (dht: Avoid dict log flooding for internal MDS xattr) posted (#2) for review on release-4.1 by N Balachandran

Comment 5 Nithya Balachandran 2018-10-08 04:57:51 UTC
https://review.gluster.org/#/c/glusterfs/+/19981/ is already merged in master.

Comment 6 Shyamsundar 2018-10-23 15:07:59 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/