Bug 1576984
| Summary: | [RFE] Advanced settings - ability to reset to default value, delete newly added keys | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Gregg Tanzillo <gtanzill> | |
| Component: | Appliance | Assignee: | Yuri Rudman <yrudman> | |
| Status: | CLOSED ERRATA | QA Contact: | Tasos Papaioannou <tpapaioa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 5.10.0 | CC: | abellott, gquites, gtanzill, jfrey, jhenner, jprause, obarenbo, simaishi, tpapaioa, yrudman | |
| Target Milestone: | GA | Keywords: | FutureFeature | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.10.0.3 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1592929 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-07 23:02:11 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1353301, 1358448, 1592929 | |||
|
Description
Gregg Tanzillo
2018-05-10 22:07:40 UTC
One idea to do this in a simple way with the current advanced settings UI would be to support "magic keywords" as values that could indicate how a setting should be saved. For example- A value of [default] would instruct the model to delete the existing "setting_changes" row for that key which would result in making the default values (from settings.yml) be the current value. If the key was not one of the out of the box settings it would result in deleting the key and value altogether. A values of [nil] would force saving a literal nil as the value. Please assess the impact of this issue and update the severity accordingly. Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition. If it's something like a tracker bug where it doesn't matter, please set the severity to Low. Above PR addressed deleting nodes and values. Setting value to nil - I would suggest to track it separately New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/5d1861e6f0effd4ca05129b0acccda70a5dfa0f3 commit 5d1861e6f0effd4ca05129b0acccda70a5dfa0f3 Author: Yuri Rudman <yrudman> AuthorDate: Fri Jun 1 10:16:01 2018 -0400 Commit: Yuri Rudman <yrudman> CommitDate: Fri Jun 1 10:16:01 2018 -0400 add magic words <<reset>>, <<rest_all>>. If <<reset>> word passed as value for node or leaf than that node or leaf deleted for selected resource. If <<reset_all> passed that leaf/node deleted for all resorces. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1576984 lib/vmdb/settings.rb | 39 +- 1 file changed, 38 insertions(+), 1 deletion(-) I don't understand the reset_all piece of this and I would like to get more clarity before moving this forward. Updated the BZ title to reflect what is actually being changes. Only the <<reset>> functionality will be implemented, which handles both the "inherit" from Zone or Region case, as well as the "delete" a newly added key case. I will open a separate BZ for an <<enforce>> keyword which would be used to "push down" overrides to child resources. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/72b7ec50997f210242fb583771b5e98066efb199 commit 72b7ec50997f210242fb583771b5e98066efb199 Author: Jason Frey <jfrey> AuthorDate: Tue Jun 19 10:44:21 2018 -0400 Commit: Jason Frey <jfrey> CommitDate: Tue Jun 19 10:44:21 2018 -0400 Remove <<reset_all>> magic value from Settings The user expectations around <<reset_all>> are too complicated, and so this is being removed. In doing so, the logic for <<reset>> has been greatly simplified. A different keyword is expected to implemented in a separate PR to deal with enforcing a setting at the Region or Zone level and pushing that value down to the child resources. (This is not how <<reset_all>> presently works, but that is a feature we expect to need) https://bugzilla.redhat.com/show_bug.cgi?id=1576984 lib/vmdb/settings.rb | 59 +- spec/lib/vmdb/settings_spec.rb | 127 +- 2 files changed, 91 insertions(+), 95 deletions(-) Opened https://github.com/ManageIQ/manageiq-ui-classic/pull/4224 to discuss presentation of the new <<reset>> keyword to the user. New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/3c5fe03a8cb291f6f9cb43ee2fbfba73b0299c3a commit 3c5fe03a8cb291f6f9cb43ee2fbfba73b0299c3a Author: Jason Frey <fryguy9> AuthorDate: Wed Jun 27 14:40:23 2018 -0400 Commit: Jason Frey <fryguy9> CommitDate: Wed Jun 27 14:40:23 2018 -0400 Add guidance text for new <<reset>> magic word https://bugzilla.redhat.com/show_bug.cgi?id=1576984 app/helpers/ops_helper.rb | 25 +- app/views/ops/_settings_advanced_tab.html.haml | 4 + 2 files changed, 22 insertions(+), 7 deletions(-) Verified on 5.10.0.6. *** Bug 1444048 has been marked as a duplicate of this bug. *** *** Bug 1358448 has been marked as a duplicate of this bug. *** *** Bug 1358433 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:0212 |