Bug 157721

Summary: DVD size limit
Product: [Fedora] Fedora Reporter: David Kuestler <dkuestler>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Mike McLean <mikem>
Severity: medium Docs Contact:
Priority: medium    
Version: 3   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-05-16 13:56:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description David Kuestler 2005-05-14 02:16:53 UTC
Description of problem:
When building DVD images I can not fill the DVD.

Version-Release number of selected component (if applicable):
Long standing problem - all versions ;-)

How reproducible:
Add extra packages to the standard distribution.

Steps to Reproduce:
1. Copy standard distribution packages to a work area.
2. Add extra packages and modify configuration files as necessary.
3. Try to build DVD.
  
Actual results:
DVD fills to 4.2G and overflows to next DVD.

Expected results:
DVD fills to 4.4G.

Additional info:
The problem is caused by an unsigned integer overflow.
The solution is to use a long integer.
The patch ( also fix a syntax error ) :

diff -urN anaconda-10.2.0.47.orig/scripts/splittree.py
anaconda-10.2.0.47/scripts/splittree.py
--- anaconda-10.2.0.47.orig/scripts/splittree.py	2005-04-01 09:16:56.000000000 +1000
+++ anaconda-10.2.0.47/scripts/splittree.py	2005-04-16 10:17:16.912379403 +1000
@@ -103,14 +103,14 @@
         self.logfile = []
 
 
-    def getSize(seld, path, blocksize=None):
+    def getSize(self, path, blocksize=None):
         """Gets the size as reported by du -s"""
 
         if blocksize:
             p = os.popen("du -s --block-size=1 %s" % path, 'r')
             thesize = p.read()
             p.close()
-            thesize = int(string.split(thesize)[0])
+            thesize = long(string.split(thesize)[0])
             return thesize
         else:
             p = os.popen("du -sh %s" % path, 'r')

Comment 1 Chris Lumens 2005-05-16 13:56:58 UTC
Fixed in CVS.  Thanks for the patch.