Bug 1577872
| Summary: | Apply upstream fixes for "ls" and "date" | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rafal Luzynski <digitalfreak> |
| Component: | coreutils | Assignee: | Kamil Dudka <kdudka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | admiller, jamartis, jarodwilson, kdudka, kzak, ooprala, ovasik, p, piotrdrag, skisela, twaugh |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | coreutils-8.29-11.fc29 coreutils-8.29-7.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-06-04 13:16:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1546484 | ||
|
Description
Rafal Luzynski
2018-05-14 10:19:33 UTC
We can certainly pick the fixes from upstream. Do you know which gnulib commits exactly are needed to fix this? The coreutils commits you refer to just make coreutils pull a new gnulib snapshot while building coreutils from git. This would have too many side effects to go to a stable release of Fedora. We recently updated just a single gnulib module (fts) to the latest upstream snapshot and it triggered regressions in find and du (see bug #1558249). So we need to be careful... (In reply to Kamil Dudka from comment #1) > We can certainly pick the fixes from upstream. Do you know which gnulib > commits exactly are needed to fix this? Are you sure you want to fix gnulib which is a git submodule? OK, if you want, please start with this one which may be sufficient: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4a236f1 If not then also those two: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=b5d3175 http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=703dcf1 Also worth looking: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=646a44e http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=88cfbe6 > The coreutils commits you refer to just make coreutils pull a new gnulib > snapshot while building coreutils from git. I thought it would be easier. But: > This would have too many side > effects to go to a stable release of Fedora. We recently updated just a > single gnulib module (fts) to the latest upstream snapshot and it triggered > regressions in find and du (see bug #1558249). So we need to be careful... ... I see, OK. Also, I forgot to say: the gnulib updates should be helpful to add %OB/%Ob/%Oh support to date command. Regarding "ls -l" probably the only patch required is this one: http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=5ed2018 Kamil, I don't know what is your relationship with the upstream. Would it be easier if 8.30 was officially released? Do you participate in making this decision? (In reply to Rafal Luzynski from comment #2) > Are you sure you want to fix gnulib which is a git submodule? It is a git submodule if you build coreutils from the upstream git repository. However, if you build coreutils from a release tarball, you simply have to patch gnulib source code directly because there is no git submodule to update and no script to re-import the selected gnulib snapshot into the source tree. > Also, I forgot to say: the gnulib updates should be helpful to add > %OB/%Ob/%Oh support to date command. Regarding "ls -l" probably the only > patch required is this one: > > http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=5ed2018 Thanks for all the references! I will give it a try. > Kamil, I don't know what is your relationship with the upstream. Would it be > easier if 8.30 was officially released? Unless the release is properly tested by upstream/downstream consumers (usually as in advance announced pre-releases), the resulting package will not be more stable than if we just built the latest upstream snapshot from git HEAD. > Do you participate in making this decision? Not really. I can tell them my opinion on the upstream mailing list, similarly as you ;-) coreutils-8.29-7.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-07e4af6bcf coreutils-8.29-7.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-07e4af6bcf coreutils-8.29-7.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. Thank you for providing this fix to Fedora 28. Looks correct! Perfect. Thanks for confirmation! |