Bug 1577888

Summary: SDN: Network provider edit/delete/add buttons still enabled
Product: Red Hat CloudForms Management Engine Reporter: thiebaut fischer <tfischer>
Component: ProvidersAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, dmetzger, gblomqui, hkataria, jfrey, jhardy, lavenel, mfeifer, mmojzis, mpovolny, mzazrivec, ndhandre, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sdn:network
Fixed In Version: 5.10.0.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-22 14:49:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
configuration buttons options enabled on ec2 network provider none

Description thiebaut fischer 2018-05-14 11:36:42 UTC 
Created attachment 1436131 [details]
configuration buttons options enabled on ec2 network provider

Description of problem:
The buttons are still enabled for providers Azure/EC2/GCE, while Create/edit/delete actions are only available on RHOS

Version-Release number of selected component (if applicable):
Version 5.9.2.4.20180501195858_35dc609


How reproducible:
Always

Steps to Reproduce:
1. Setup a cloud provider
2. go to network/ network provider
3. check a provider and click on configuration

Actual results:
See the buttons enabled

Expected results:
see buttons grey

Additional info:
see screenshot
Comment 2 Greg Blomquist 2018-05-16 12:50:06 UTC 
We should change the network provider to indicate that it doesn’t support edit/delete because it’s tied directly to the cloud provider that owns it.
Comment 8 Milan Zázrivec 2018-06-19 11:25:16 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/4162
Comment 9 CFME Bot 2018-06-21 12:20:18 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/7bee73fc41a56f3d4ff2aac6d42da558c9ff9a47
commit 7bee73fc41a56f3d4ff2aac6d42da558c9ff9a47
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Tue Jun 19 07:17:25 2018 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Tue Jun 19 07:17:25 2018 -0400

    Disallow network manager edit if the network manager doesn't support it

    https://bugzilla.redhat.com/show_bug.cgi?id=1577888

 app/controllers/ems_common.rb | 7 +
 app/controllers/ems_network_controller.rb | 7 +
 2 files changed, 14 insertions(+)
Comment 10 Matouš Mojžíš 2018-09-25 14:51:35 UTC 
These functions should be also for RHOS enabled.
Comment 14 Milan Zázrivec 2019-03-14 15:32:57 UTC 
Right now it seems the only provider that supports network manager edit
is Nuage, so this bz can be moved to POST.
Comment 16 Matouš Mojžíš 2019-05-06 13:55:19 UTC 
Verified for 5.10.4.1. Actions are disabled for AWS/Azure/RHOS.