Bug 1578132

Summary:	python-sphinxcontrib-websupport FTBFS with Sphinx 1.7
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-sphinxcontrib-websupport	Assignee:	Javier Peña <jpena>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jpena
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-16 10:16:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1565020

Description Miro Hrončok 2018-05-14 20:46:24 UTC

I am rebasing Python 3.7 in Copr an I'm now blocked because python-sphinxcontrib-websupport FTBFS with Sphinx 1.7. I believe we need to backport this commit:

https://github.com/sphinx-doc/sphinxcontrib-websupport/commit/ebe84efc1a869da8d5689c706cdcf6ea864f0d9b

See also the issue for releasing this:

https://github.com/sphinx-doc/sphinxcontrib-websupport/issues/14

+ py.test tests/
============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.4.2, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILD/sphinxcontrib-websupport-88d4fdd163efdeaab91a105b7980c42078ed3417, inifile:
collected 0 items / 2 errors

==================================== ERRORS ====================================
________________ ERROR collecting tests/test_searchadapters.py _________________
ImportError while importing test module '/builddir/build/BUILD/sphinxcontrib-websupport-88d4fdd163efdeaab91a105b7980c42078ed3417/tests/test_searchadapters.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_searchadapters.py:16: in <module>
    from test_websupport import sqlalchemy_missing
tests/test_websupport.py:26: in <module>
    from util import rootdir, tempdir
tests/util.py:30: in <module>
    from sphinx.deprecation import RemovedInSphinx17Warning
E   ImportError: cannot import name RemovedInSphinx17Warning
__________________ ERROR collecting tests/test_websupport.py ___________________
ImportError while importing test module '/builddir/build/BUILD/sphinxcontrib-websupport-88d4fdd163efdeaab91a105b7980c42078ed3417/tests/test_websupport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_websupport.py:26: in <module>
    from util import rootdir, tempdir
tests/util.py:30: in <module>
    from sphinx.deprecation import RemovedInSphinx17Warning
E   ImportError: cannot import name RemovedInSphinx17Warning
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 2 error in 0.43 seconds ============================

Comment 1 Javier Peña 2018-05-16 09:35:11 UTC

I have updated the spec to use a newer commit that includes the Sphinx 1.7 build, and built it in Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=26988932

Is a Rawhide build enough, or would you need me to backport the fix to f28 too?

Comment 2 Miro Hrončok 2018-05-16 10:16:13 UTC

A git push to master was enough. Thanks.