Bug 157832

Summary:

httpd segfault on logrotate

Product:

Red Hat Enterprise Linux 3

Reporter:

Neil Horman <nhorman>

Component:

httpd

Assignee:

Joe Orton <jorton>

Status:

CLOSED ERRATA

QA Contact:

Severity:

medium

Docs Contact:

Priority:

medium

Version:

3.0

CC:

tao

Target Milestone:

---

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

RHBA-2005-621

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2005-09-28 17:05:04 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

156320

Attachments:

Description	Flags
customer provided core file from httpd crash	none
patch to avoid dereferencing of NULL pointer	none

Description Neil Horman 2005-05-16 12:20:52 UTC

Description of problem:
httpd appears to have race problems in its cleanup handlers, in that it appears
those cleanup handlers can be run from multiple threads in the httpd process.

Version-Release number of selected component (if applicable):
httpd-2.0.46

How reproducible:
not sure

Steps to Reproduce:
N/A/
  
Actual results:
when receiving SIGHUP, httpd segfaults

Expected results:
server should restart

Additional info:

Comment 1 Neil Horman 2005-05-16 12:21:04 UTC

Created attachment 114418 [details]
customer provided core file from httpd crash

Comment 2 Neil Horman 2005-05-16 12:26:34 UTC

Created attachment 114419 [details]
patch to avoid dereferencing of NULL pointer

This isn't the most graceful solution, given the problem description, but it
seems reasonable, since it seems that re-writing httpd to be thread safe in its
cleanup handlers could be fairly invasive.  It basically just checks for NULL
on calls to apr_file_close.  My other thought would be to add fields to
registered cleanup handlers to mark them as being "run" so as to prevent double
execution, but this seemed more appropriate to me.

Comment 3 Joe Orton 2005-05-16 12:30:05 UTC

Thanks for the report, but there is too much analysis here and not enough
information.

What version of the httpd package is being used?  Do you have a precise repro
case for this issue?  What configuration is being used, which triggers this? 
Why are you talking about "threads"?  (/usr/sbin/httpd does not use threads)

Comment 20 Red Hat Bugzilla 2005-09-28 17:05:05 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2005-621.html