Bug 1578343

Summary: [OSP13] Heat in DEBUG logs private keys when a template creates a keypair
Product: Red Hat OpenStack Reporter: Matthew Booth <mbooth>
Component: openstack-keystoneAssignee: Nathan Kinder <nkinder>
Status: CLOSED CURRENTRELEASE QA Contact: nlevinki <nlevinki>
Severity: medium Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: apevec, dasmith, dciabrin, eglynn, jhakimra, jschluet, kchamart, lhh, lyarwood, mbooth, mburns, nkinder, nova-maint, pablo.iranzo, sbaker, sbauza, sgordon, shardy, srevivo, vromanso, vstinner
Target Milestone: ---Keywords: Triaged, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1575945
: 1612890 (view as bug list) Environment:
Last Closed: 2019-10-15 09:44:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1575945, 1578346, 1578347, 1612890    
Bug Blocks:    

Comment 3 Matthew Booth 2018-05-15 11:21:08 UTC
Submitted a backport for upstream queens: https://review.openstack.org/568555

Comment 5 Victor Stinner 2018-06-05 12:51:23 UTC
I requested Release oslo.utils 3.35.1 for Queens:
https://review.openstack.org/#/c/572373/

Comment 6 Victor Stinner 2018-06-06 13:32:29 UTC
I cannot rebase oslo.utils to 3.35.1 because this issue is not marked as a blocker issue. Since the issue only impacts log in DEBUG mode, I don't think that it deserves to block the release. It can wait for a z-stream release. If you disagree, please mark the issue as a blocker, so I can do the rebase :-)

Comment 9 Victor Stinner 2018-07-12 14:09:53 UTC
While the Oslo part is done, keystoneauth needs to be modified to use mask_password(): see https://bugzilla.redhat.com/show_bug.cgi?id=1578347#c11

I changed the component of this issue to openstack-keystone.

Comment 11 Damien Ciabrini 2018-08-06 14:48:03 UTC
Since that bug requires a fix in both python-oslo-utils and openstack-keystone, I have just clone it [1] to track the python-oslo-utils fix in a dedicated bz.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1612890