Bug 1578646

Summary: [day2] Removal of the unwanted sections from the config file of create volume operation.
Product: [oVirt] cockpit-ovirt Reporter: Mugdha Soni <musoni>
Component: GdeployAssignee: Parth Dhanjal <dparth>
Status: CLOSED CURRENTRELEASE QA Contact: Mugdha Soni <musoni>
Severity: medium Docs Contact:
Priority: medium    
Version: 0.11.20CC: bshetty, bugs, musoni, rhs-bugs, sabose, sankarshan, sasundar
Target Milestone: ovirt-4.2.5Flags: rule-engine: ovirt-4.2+
rule-engine: devel_ack+
bshetty: testing_ack+
Target Release: 0.11.29   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.11.29-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1578644 Environment:
Last Closed: 2018-07-31 15:25:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1578644, 1596277    
Attachments:
Description Flags
conf file doc none

Description Mugdha Soni 2018-05-16 05:24:39 UTC 
+++ This bug was initially created as a clone of Bug #1578644 +++

Description of problem:
-------------------------------------------------------------
There is presence of unwanted sections in the config file of the "create volume" as these are all host level services /parameters.These sections include :-
1.Vdsm  tool configure command.
2.Firewalld services
3.Blacklisting all disks scripts(script 3)
4.Gluster hooks
5.SE linux
7.chronyd services
8.command usrmod(shell 3)

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.11.999-0.0.master.el7.noarch

How reproducible:
---------------------------------------------------------------
Everytime

Steps to Reproduce
---------------------------------------------------------------
1.Successfully deploy gluster and hosted engine.

2.After the deployment of hosted engine go to the "hosted engine" tab in cockpit UI and click on "create volume".

3.Fill in all the required parameters for addition of creating an extra volume and then validate the config file.

4. In the config file user can have the presence of these unwanted sections.

Actual results:
-------------------------------------------------------------------
Presence of these unwanted sections.

Expected results:
-------------------------------------------------------------------
Absence of these unwanted sections.


Additional info:
----------------------------------------
[service1]
action=enable
service=chronyd

[service2]
action=restart
service=chronyd

[shell2]
action=execute
command=vdsm-tool configure --force

[script3]
action=execute
file=/usr/share/gdeploy/scripts/blacklist_all_disks.sh
ignore_script_errors=no

[selinux]
yes

[firewalld]
action=add
ports=111/tcp,2049/tcp,54321/tcp,5900/tcp,5900-6923/tcp,5666/tcp,16514/tcp,54322/tcp
services=glusterfs

[script2]
action=execute
file=/usr/share/gdeploy/scripts/disable-gluster-hooks.sh

[shell3]
action=execute
command=usermod -a -G gluster qemu

--- Additional comment from Red Hat Bugzilla Rules Engine on 2018-05-16 01:21:20 EDT ---

This bug is automatically being proposed for the current release of Red Hat Hyperconverged Infrastructure (RHHI) under active development, by setting the release flag 'rhhi‑2.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.
Comment 1 Parth Dhanjal 2018-05-23 09:00:21 UTC 
Mughda! Can you please elaborate a little on what all are the unwanted sections in the gdeploy file?
Comment 2 SATHEESARAN 2018-06-01 14:55:14 UTC 
(In reply to Parth Dhanjal from comment #1)
> Mughda! Can you please elaborate a little on what all are the unwanted
> sections in the gdeploy file?

The unwanted sections are listed down in comment0
Comment 3 Mugdha Soni 2018-06-04 05:48:18 UTC 
Reply to Satheesaran and Parth from comment #2 #1)

The section which need to removed  are elaborated in additional info space .
Comment 4 Sandro Bonazzola 2018-06-29 15:41:47 UTC 
Referenced patch miss Bug-Url tag, using Bug-Id instead but it's included in cockpit-ovirt-0.11.29-1 tag.
Comment 5 Mugdha Soni 2018-07-11 09:55:01 UTC 
Created attachment 1458037 [details]
conf file doc
Comment 6 Mugdha Soni 2018-07-11 10:00:30 UTC 
Tested with the following:
(a)rhvh-4.2.5.0-0.20180702.0+1
(b)cockpit-ovirt-dashboard-0.11.29-1.el7ev.noarch(3
(c)gdeploy-2.0.2-27.el7rhgs.noarch

The unwanted sections were removed from the create volume conf file so moving this bug to verified.
Comment 7 Sandro Bonazzola 2018-07-31 15:25:52 UTC 
This bugzilla is included in oVirt 4.2.5 release, published on July 30th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.