Bug 1578725

Summary: etcd system container code should be cleaned up
Product: OpenShift Container Platform Reporter: Johnny Liu <jialiu>
Component: InstallerAssignee: Michael Gugino <mgugino>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.10.0CC: aos-bugs, jokerman, mmccomas, wmeng
Target Milestone: ---   
Target Release: 3.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-11 07:20:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Johnny Liu 2018-05-16 09:48:04 UTC
Description of problem:

According to https://bugzilla.redhat.com/show_bug.cgi?id=1578204#c5, and etcd is running as static pod, so etcd system container code should be cleaned up.

$ git describe
openshift-ansible-3.10.0-0.47.0


$ grep system_container * -r|grep -v openshift-ansible.spec
roles/etcd/tasks/runtime.yml:  when: etcd_container_service.status.ActiveState == 'active' and not l_is_etcd_system_container
roles/etcd/tasks/runtime.yml:  when: etcd_container_service.status.ActiveState == 'active' and l_is_etcd_system_container
roles/etcd/tasks/version_detect.yml:    - not l_is_etcd_system_container | bool and not l_etcd_static_pod | bool
roles/etcd/tasks/version_detect.yml:    - not l_is_etcd_system_container | bool and not l_etcd_static_pod | bool
roles/etcd/tasks/version_detect.yml:    - l_is_etcd_system_container | bool and not l_etcd_static_pod | bool
roles/etcd/tasks/version_detect.yml:    - l_is_etcd_system_container | bool and not l_etcd_static_pod
roles/etcd/defaults/main.yaml:l_is_etcd_system_container: "{{ (openshift_use_etcd_system_container | default(openshift_use_system_containers | default(false)) | bool) }}"
roles/etcd/defaults/main.yaml:r_etcd_common_etcd_runtime: "{{ 'runc' if l_is_etcd_system_container else ('static_pod' if l_etcd_static_pod else ('docker' if openshift_is_containerized else 'host')) }}"
roles/openshift_node/tasks/systemd_units.yml:  import_tasks: node_system_container.yml



Version-Release number of the following components:
rpm -q openshift-ansible
rpm -q ansible
ansible --version

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 Scott Dodson 2018-05-16 12:44:59 UTC
If we don't consider this to be a 3.10 blocker i'm fine, but if we go that route I think we should block the install when we detect hosts with `containerized=true` or `openshift_use_system_containers=true`

Comment 2 Scott Dodson 2018-05-16 13:42:54 UTC
After discussion within the team we've decided that this code is necessary to facilitate upgrade and can only be removed in 3.11.

Comment 3 Scott Dodson 2018-08-01 20:22:21 UTC
This is already complete for 3.11.

Comment 4 Johnny Liu 2018-08-03 07:24:23 UTC
Verified this bug with openshift-ansible-3.11.0-0.10.0.git.0.91bb588None.noarch, and PASS.

Only node_system_container is left, the other are removed.
# grep system_container * -r|grep -v openshift-ansible.spec
playbooks/openshift-node/private/registry_auth.yml:      tasks_from: node_system_container_install.yml
roles/openshift_node/tasks/node_system_container.yml:- import_tasks: node_system_container_install.yml
roles/openshift_node/tasks/systemd_units.yml:  import_tasks: node_system_container.yml

Comment 6 errata-xmlrpc 2018-10-11 07:20:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2652