Bug 1578726

Summary: dbus-python FTBFS with Python 3.7
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: dbus-pythonAssignee: Alternative GTK desktop environments <alt-gtk-de-sig>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: alexl, alt-gtk-de-sig, cstratak, john.j5live, mclasen, rdieter, rhughes, rstrode, sandmann, shawn.p.huang, stefano
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dbus-python-1.2.8-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-23 12:40:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1539950    
Bug Blocks: 1565020    
Attachments:
Description Flags
build.log from copr
none
root.log from copr
none
build.log from copr with python3-build/test-suite.log none

Description Miro Hrončok 2018-05-16 09:56:18 UTC
Created attachment 1437208 [details]
build.log from copr

I'm bootstrapping Python 3.7 in copr. dbus-python fails to build due to 3 failed tests:

FAIL: test/test-client.py
FAIL: test/test-p2p.py
FAIL: test/test-signals.py

Version-Release number: 1.2.4-13.fc29

Will attach build and root logs.

Comment 1 Miro Hrončok 2018-05-16 09:57:27 UTC
Created attachment 1437209 [details]
root.log from copr

Comment 2 Miro Hrončok 2018-05-23 10:37:50 UTC
Created attachment 1440545 [details]
build.log from copr with python3-build/test-suite.log

  File "../test/test-client.py", line 331
    for async in (True, False):
            ^
SyntaxError: invalid syntax

  File "/builddir/build/BUILD/dbus-python-1.2.4/python3-build/../test/test-service.py", line 278
    def AsynchronousMethod(self, async, fail, variant, return_cb, error_cb):
                                     ^
SyntaxError: invalid syntax


This is related to PEP 492 https://www.python.org/dev/peps/pep-0492/

async is now a keyword.

Comment 3 Miro Hrončok 2018-05-23 11:46:43 UTC
The async thing is fixed in:

commit 2d5ccd0cb9e580732d0abfbf8a97b1bf779d2a9e
Author: Simon McVittie <smcv>
Date:   Mon Jan 29 10:30:43 2018 +0000

    Avoid using async keyword
    
    Signed-off-by: Simon McVittie <smcv>



This is included in 1.2.8.

Comment 4 Miro Hrončok 2018-05-23 12:02:55 UTC
I confirm that 1.2.8 builds with CPython 3.7.