Bug 1578731
| Summary: | Allow logrotate configuration to control log retention based on age | |||
|---|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Nathan Kinder <nkinder> | |
| Component: | puppet-tripleo | Assignee: | RHOS Maint <rhos-maint> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavan <pkesavar> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 13.0 (Queens) | CC: | agurenko, bdobreli, ealcaniz, hrybacki, jjoyce, josorior, jschluet, knoha, pablo.iranzo, pkesavar, slinaber, tvignaud | |
| Target Milestone: | z2 | Keywords: | TestOnly, Triaged, ZStream | |
| Target Release: | 13.0 (Queens) | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | puppet-tripleo-8.3.4-2.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1627740 (view as bug list) | Environment: | ||
| Last Closed: | 2018-11-13 11:46:04 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1627740 | |||
|
Description
Nathan Kinder
2018-05-16 10:10:45 UTC
*** Bug 1578854 has been marked as a duplicate of this bug. *** I'm not happy with https://review.openstack.org/569805 and https://review.openstack.org/569806, and I have to tweak the maxsize defaults prolly. As is, the postrotate script purges all files in /var/log/containers, if there were *any* files rotated in /var/log/containers. So logfiles not reaching the maxsize (defaults to 10M) will be removed and never rotated. So tweaking should make those "any" files to become "all", which I think may be lowering the maxsize defaults to something low enough to put all files under rotation (logrotate has a hourly execution schedule). I wish I could instead just access the files' *real* creation time, then I'd alter the postrotate script to purge only the files having its life-time expired. But that's not the case sadly and cannot be done w/o real creation time reported by FS drivers. Attempting to improve things in https://review.openstack.org/#/c/569938 It should be fine now with https://review.openstack.org/#/c/570328 added on top. @Juan, the part of the issue addressing containerized logrotate and containerized services is done, patches in stable/queens. Please feel free to take it over for the remaining work - host services and host logroatate/journald configuration. Hello Bogdan, Your comment to Juan is not have needinfo flag. Could you add needinfo to Juan and ask Juan to proceed this bugzilla? Best Regards, Keigo Noha Hello Bogdan, Could you proceed this bugzilla forward? In the upstream, all related work seemed to be done. Can we backport the fixes into RHOSP13? Best Regards, Keigo Noha Hello Bogdan, It looks that the upstream fixes were merged and RHOSP13z3 candidate contains the fixes. And puppet-tripleo-8.3.4-2.el7 seems to contain the fix in this bugzilla. Is it correct? If yes, we can close this bugzilla. Best Regards, Keigo Noha Yes, looks correct. According to our records, this should be resolved by puppet-tripleo-8.3.4-5.el7ost. This build is available now. |