Bug 1579302

Summary:	support more granularity in cluster cpu types
Product:	[oVirt] ovirt-engine	Reporter:	Michal Skrivanek <michal.skrivanek>
Component:	BLL.Virt	Assignee:	Tomas Jelinek <tjelinek>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Vitalii Yerys <vyerys>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.2.3	CC:	bugs, vyerys
Target Milestone:	ovirt-4.2.4	Flags:	rule-engine: ovirt-4.2+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.2.4	Doc Type:	Enhancement
Doc Text:	Feature: Support distinguishing cpus also by features they support, not just by model. Reason: If a new CPU feature is important, it is important to be able to distinguish if the CPU with some model also supports this feature and than require this feature also for VMs. Result: Now, it is possible to distinguish CPUs also by features and require them for the VMs. CPU types take additional flags in addition to their libvirt name. Like e.g. SandyBridge, you can specify custom CPU as “SandyBridge,+xyz” or “SandyBridge,-xyz” to add or remove arbitrary individual CPU flags in addition to what the named model contains.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-26 08:38:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Skrivanek 2018-05-17 10:24:35 UTC

vdsm always supported more granularity than just libvirt cpu models. Let's support it in engine too.

Comment 1 Vitalii Yerys 2018-06-20 15:10:12 UTC

Verified on rhvm-4.2.4.4-0.1.el7_3.noarch

Notes: Before verification one must be sure that Host/engine and other hw support flags that are to be added to the VM.

Verification steps:

1. Create VM
2. "Run once" VM with SandyBridge,+pcid,+spec-ctrl,+ssbd (NOTE: Host must support this features)
3. VM should start successfully.
4. in the VM console verify if flags are adopted by running the command: cat /proc/cpuinfo - flags added during run once should be present in the output.

Comment 2 Sandro Bonazzola 2018-06-26 08:38:23 UTC

This bugzilla is included in oVirt 4.2.4 release, published on June 26th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.