Bug 1579361

Summary: Property error: resources[69].properties: Property DockerKeepalivedConfigImage not assigned
Product: Red Hat OpenStack Reporter: Filip Hubík <fhubik>
Component: openstack-tripleo-heat-templatesAssignee: Emilien Macchi <emacchi>
Status: CLOSED ERRATA QA Contact: Filip Hubík <fhubik>
Severity: medium Docs Contact:
Priority: medium    
Version: 14.0 (Rocky)CC: agurenko, aschultz, emacchi, jjoyce, mburns, rhosp-bugs-internal, shrjoshi, slinaber
Target Milestone: betaKeywords: Automation, AutomationBlocker, Triaged
Target Release: 14.0 (Rocky)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-9.0.0-0.20180710202746.d2994ca.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-11 11:49:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Filip Hubík 2018-05-17 13:08:11 UTC
Description of problem:
Deployment of overcloud fails with error:
...
STDOUT:

Waiting for messages on queue 'tripleo' with no timeout.
Heat Stack create failed.
Heat Stack create failed.
Removing the current plan files
Uploading new plan files
Plan updated.
Processing templates in the directory /tmp/tripleoclient-GeZND4/tripleo-heat-templates
WARNING: Following parameter(s) are deprecated and still defined. Deprecated parameters will be removed soon!
  OvercloudControlFlavor
Deploying templates in the directory /tmp/tripleoclient-GeZND4/tripleo-heat-templates

 Stack overcloud/0c2f8757-824e-4f04-a662-54bdf9ece9a3 CREATE_FAILED 

overcloud.ControllerServiceChain.ServiceChain:
  resource_type: OS::Heat::ResourceChain
  physical_resource_id: 
  status: CREATE_FAILED
  status_reason: |
    resources.ServiceChain: Property error: resources[69].properties: Property DockerKeepalivedConfigImage not assigned

$ openstack stack failures list overcloud produces:

overcloud.ControllerServiceChain.ServiceChain:
  resource_type: OS::Heat::ResourceChain
  physical_resource_id: 
  status: CREATE_FAILED
  status_reason: |
    resources.ServiceChain: Property error: resources[69].properties: Property DockerKeepalivedConfigImage not assigned

Version-Release number of selected component (if applicable):
OSP14

How reproducible:
Always

Steps to Reproduce:
1. Deploy OSP14 with 1uc, 1contr, 1comp, 1ceph topology, puddle 2018-05-16.2
2. Use overcloud deploy script to reproduce:

$ cat overcloud_deploy.sh 
openstack overcloud deploy \
--timeout 100 \
--templates /usr/share/openstack-tripleo-heat-templates \
--stack overcloud \
--libvirt-type kvm \
--ntp-server 10.35.255.6 \
-e /home/stack/virt/internal.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e /home/stack/virt/hostnames.yml \
-e /usr/share/openstack-tripleo-heat-templates/environments/ceph-ansible/ceph-ansible.yaml \
-e /home/stack/virt/debug.yaml \
-e /home/stack/virt/nodes_data.yaml \
--environment-file /usr/share/openstack-tripleo-heat-templates/environments/services/sahara.yaml \
--environment-file /usr/share/openstack-tripleo-heat-templates/environments/cinder-backup.yaml \
-e /home/stack/virt/docker-images.yaml \
--log-file overcloud_deployment_87.log

Actual results:
OC deployment fails with mentioned error reported.

Additional info:
openstack-tripleo-heat-templates.noarch
9.0.0-0.20180501093219.7eb4eaf.el7ost
openstack-tripleo-common.noarch
9.0.2-0.20180501093725.cc190aa.el7ost 
openstack-tripleo-common-containers.noarch
9.0.2-0.20180501093725.cc190aa.el7ost

Comment 7 bigswitch 2018-09-25 17:51:23 UTC
Hi,

We're seeing this same error (KellalivedConfigImage not found) for Queens release when deploying by creating a separate plan folder and downloading the plan, and using that as the templates directory.

We did that to get a rendered version of some of the j2 files.
Comment #4 mentions a workaround, but its not publicly visible. Would it be possible to share the diff and see if its the same issue that we're observing?

Thanks!
Don Jayakody

Comment 8 Alex Schultz 2018-09-25 18:55:20 UTC
The plan-environment.yaml needs to include:

  - path: environments/docker.yaml
  - path: environments/docker-ha.yaml

Or it will try and pull in Keepalived instead of using haproxy/pacemaker.  This is the default for OSP but is not the default for the upstream.  Alternatively just pass -e <tht>/environments/docker.yaml and -e <tht>/environments/docker-ha.yaml on the command line when you deploy.

Comment 9 bigswitch 2018-09-25 18:59:51 UTC
Thanks for the reply Alex! I've checked the "plan-environment-yaml". It had docker paths you mentioned above. Any other clues that you can think of why we are getting the same failure?


Here's the content of the "plan-environment-yaml":

description: 'Default Deployment plan

  '
environments:
- path: overcloud-resource-registry-puppet.yaml
- path: environments/docker.yaml
- path: environments/docker-ha.yaml
- path: environments/containers-default-parameters.yaml

Thanks.
Don

Comment 10 Alex Schultz 2018-09-25 19:46:06 UTC
No idea. Would have to see the entire deployment command and templates. Feel free to open up a different bug than this one to track that.

Comment 11 bigswitch 2018-09-25 22:45:04 UTC
Thanks Alex. For some reason, passing the "-e <tht>/environments/docker.yaml and -e <tht>/environments/docker-ha.yaml" worked for us. 

Thanks for your help!

Comment 12 Alex Schultz 2018-09-26 17:53:55 UTC
Good to know. It can be ordering so even though it's in the default plan, if you pass in something that later overrides what is in there you can end up with the same problem.  By default the docker.yaml and docker-ha.yaml should be enabled so if it wasn't it would be good to take a look at your templates and make sure you aren't including something that is causing the docker items to be no longer set.  It's likely the docker-ha.yaml items that were causing the problems (that removes the keepalive setup).

Comment 13 Filip Hubík 2018-10-02 09:50:25 UTC
I can confirm this issue is fixed by 20180710202746.d2994ca version of package, but fails later during mistral steps. I was not able to workaround the dependent issue since it looks like newer versions of brew builds are missing https://review.openstack.org/#/c/583287/5/tripleo_common/inventory.py that could deal with it.

All in all original issue seems to be fixed.

Comment 15 errata-xmlrpc 2019-01-11 11:49:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:0045