Bug 1579416

Summary: Review Request: ghc-bdcs - Tools for managing a content store
Product: [Fedora] Fedora Reporter: Chris Lumens <clumens>
Component: Package ReviewAssignee: David Shea <dshea>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dshea, package-review
Target Milestone: ---Flags: dshea: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-18 15:07:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
package review none

Description Chris Lumens 2018-05-17 15:19:09 UTC 
Spec URL: https://clumens.fedorapeople.org/ghc-bdcs.spec
SRPM URL: https://clumens.fedorapeople.org/ghc-bdcs-0.6.1-1.fc26.src.rpm
Description: This module provides a library and various tools for managing a content store and metadata database.  These store the contents of software packages that make up a Linux distribution as well as a lot of metadata about those software packages.  Tools are included to construct those stores from pre-built software and to pull files back out to turn into bootable images.  
Fedora Account System Username: clumens
Comment 1 David Shea 2018-05-17 17:20:52 UTC 
Created attachment 1438049 [details]
package review

Ah jeez this review file is long, no wonder it took so long. My favorite part is the line saying that other packages own /lib/.build-id owned by this package, and then it lists the other packages, which is every package in Fedora. So good.

But anyway good news most of it is garbage or complaining about things that don't apply to haskell. Here's the highlights:

* The docs are too dang big. I think juhp is maybe working on something for that in cabal-rpm? I don't know, but The Guidelines are clear that we have to be as hostile as possible to developers if docs are over 1MB. https://src.fedoraproject.org/rpms/ghc-servant/blob/master/f/ghc-servant.spec is how I did it (split -devel.files into -devel-doc and -devel-nodoc in %install), and remove the -doc Provides from -devel

* Nothing owns %{_libexecdir}/%{pkgver}. Just add that to %files.

* We misspelled "included" in the desscription. That can wait for later since we can just blame upstream for now.
Comment 2 Chris Lumens 2018-05-17 17:46:53 UTC 
Okay, I've updated the links with new versions that should address all those problems.
Comment 3 David Shea 2018-05-17 18:23:42 UTC 
Looks good.
Comment 4 Gwyn Ciesla 2018-05-17 21:20:27 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-bdcs