Bug 1580060

Summary: python-httpretty FTFBS on Python 3.7
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-httprettyAssignee: Jamie Lennox <jamielennox>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cheimes, jamielennox, piotr1212
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-httpretty-0.9.5-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-08 10:54:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1572888    
Bug Blocks: 1565020, 1583418    
Attachments:
Description Flags
build.log from copr
none
root.log from copr none

Description Miro Hrončok 2018-05-19 17:28:45 UTC 
Created attachment 1438956 [details]
build.log from copr

The current python-httpretty-0.8.14-8.20161011git70af1f8.fc29 fails to build on 3.6 & 3.7. When updating to 0.9.4 as proposed in bz1572888, httpretty starts to build on Python 3.6, but not Python 3.7.

I't a very weird SSL related errors reported upstream at https://github.com/gabrielfalcao/HTTPretty/issues/337
Comment 1 Miro Hrončok 2018-05-19 17:29:05 UTC 
Created attachment 1438957 [details]
root.log from copr
Comment 2 Miro Hrončok 2018-05-30 10:49:15 UTC 
Jamie?
Comment 3 Jamie Lennox 2018-05-31 06:33:17 UTC 
Hey Miro, 

So i'm not really sure what we should be doing here. 

My maintenance of this packages is kind of a relic of it once being used in OpenStack world. However for various reasons (including how long it took to get python3 support) we removed it from there a long time ago. I've basically had nothing to do with upstream since then.

It hasn't been orphaned mostly because it's been ticking along with no problems. I'm not a fan of the library and would love to move cloud-init off of it, and to orphan it out of RPMs. 

I can take a closer look, but based on the exchange on the bug report it's not an easy fix and I wouldn't hold my breath on a fix from upstream unless it's more actively maintained that it was a few years ago.
Comment 4 Miro Hrončok 2018-05-31 08:23:48 UTC 
> would love to move cloud-init off of it

This isn't something that would happen in ~1 month, right?
Comment 5 Jamie Lennox 2018-06-01 00:00:11 UTC 
No, particularly by the time that gets released and include in a distro. 

It's either push upstream for a 3.7 compatible release and hope that happens quickly or disable RPM tests on cloud-init.
Comment 6 Miro Hrončok 2018-06-01 03:33:20 UTC 
I don't like disabling tests, but I'll try to prep a patch that disables only the httpretty+https ones.
Comment 7 Miro Hrončok 2018-06-04 10:28:09 UTC 
Tadah https://github.com/gabrielfalcao/HTTPretty/pull/339
Comment 8 Miro Hrončok 2018-06-06 19:25:06 UTC 
Ready in https://src.fedoraproject.org/rpms/python-httpretty/pull-request/2 please review and merge.
Comment 9 Miro Hrončok 2018-06-06 20:34:00 UTC 
I've verified that python-httpretty 0.9.5-1.fc29 builds fine with Python 3.7