Bug 1580109

Summary: unexpanded-macro %desc
Product: [Fedora] Fedora Reporter: Dick Marinus <dick>
Component: python-cli-helpersAssignee: Terje Røsten <terje.rosten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 28CC: terje.rosten
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-cli-helpers-1.0.2-2.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-06 13:30:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dick Marinus 2018-05-20 09:07:32 UTC
Description of problem:


Version-Release number of selected component: 1.0.1-3.fc28


How reproducible:


Steps to Reproduce:
# rpmlint python3-cli-helpers

Actual results:
python3-cli-helpers.noarch: W: unexpanded-macro %description -l C %{desc}
python3-cli-helpers.noarch: W: spelling-error %description -l en_US desc -> disc, desk, descry
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Expected results:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Additional info:

Feel free to use my fix from:
https://github.com/dbcli/copr-python-cli-helpers/commits/master

I've replaced %{desc} with the description.

Comment 1 Terje Røsten 2018-05-21 10:18:29 UTC
Hi!

Thanks for heads up!

I think I prefer this style instead:

diff --git a/python-cli-helpers.spec b/python-cli-helpers.spec
index f4f8486..8563b03 100644
--- a/python-cli-helpers.spec
+++ b/python-cli-helpers.spec
@@ -34,10 +34,11 @@ BuildRequires:  python3-tabulate
 BuildRequires:  python3-terminaltables
 BuildRequires:  python3-wcwidth
 %endif 
-%description
-CLI Helpers is a Python package that makes it easy to perform common
-tasks when building command-line apps. Its a helper library for
+%global _description\
+CLI Helpers is a Python package that makes it easy to perform common\
+tasks when building command-line apps. Its a helper library for\
 command-line interfaces.
+%description %_description
 
 %if 0%{?with_python2}
 %package -n     python2-cli-helpers
@@ -48,8 +49,7 @@ Requires:       python2-pygments >= 1.6
 Requires:       python2-tabulate >= 0.8.0
 Requires:       python2-terminaltables >= 3.0.0
 Requires:       python2-wcwidth
-%description -n python2-cli-helpers
-%{desc}
+%description -n python2-cli-helpers %_description
 %endif
 
 %if %{with python3}
@@ -60,8 +60,7 @@ Requires:       python3-pygments >= 1.6
 Requires:       python3-tabulate >= 0.8.0
 Requires:       python3-terminaltables >= 3.0.0
 Requires:       python3-wcwidth
-%description -n python3-cli-helpers
-%{desc}
+%description -n python3-cli-helpers %_description
 %endif
 
 %prep

Comment 2 Dick Marinus 2018-05-21 10:49:24 UTC
Yes, that's better.

Comment 3 Fedora Update System 2018-05-21 10:49:47 UTC
python-cli-helpers-1.0.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c7634723de

Comment 4 Fedora Update System 2018-05-21 17:16:01 UTC
python-cli-helpers-1.0.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c7634723de

Comment 5 Fedora Update System 2018-06-06 13:30:18 UTC
python-cli-helpers-1.0.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.