Bug 1580586

Summary:	Crash related to hyperlinks
Product:	[Fedora] Fedora	Reporter:	Egmont Koblinger <egmont>
Component:	vte291	Assignee:	Kalev Lember <klember>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	28	CC:	klember
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	vte291-0.52.2-1.fc28 vte291-0.50.4-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-23 15:41:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Egmont Koblinger 2018-05-21 20:46:18 UTC

A crash was discovered recently in VTE, triggered by the combination of explicit hyperlinks (a new feature of vte-0.50) and a non-aligned window size (e.g. Tilix, or maximized GNOME Terminal) due to a missing trivial boundary check.

Since GNOME Terminal handles all of its terminals in a single process, a crash causes all its terminals to disappear, making the consequences even worse.

Mainstream bugreport with technical details and steps to reproduce: https://bugzilla.gnome.org/show_bug.cgi?id=795826

Fix (for vte-0.52.x and 0.50.x): https://git.gnome.org/browse/vte/commit/?h=vte-0-52&id=5966e8bfb

F28 ships 0.52.1, F27 ships 0.50.3 as an update. Mainstream 0.52.2 and 0.50.4 have been released with this code change only (apart from the version as reported by VTE itself, of course), so instead of patching you could probably just simply bump the version number.

Older Fedora release are unaffected, since they didn't yet have support for explicit hyperlinks.

Could you guys please release a fixed package as an update for the affected distros? Thanks a lot!

Comment 1 Kalev Lember 2018-05-21 21:06:14 UTC

Thanks Egmont!

Comment 2 Fedora Update System 2018-05-21 21:06:50 UTC

gnome-terminal-3.28.2-1.fc28 vte291-0.52.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f1454efdd4

Comment 3 Fedora Update System 2018-05-21 21:16:49 UTC

vte291-0.50.4-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a88439459

Comment 4 Egmont Koblinger 2018-05-21 21:21:24 UTC

Wow, this was really quick :) Thanks Kalev!

Note: gnome-terminal 3.28.2 is not necessary in order to fix this crash. It fixes another issue though: the encodings were erroneously left untranslated in the prefs dialog. So it's nice to have it fixed too, but not that critical.

Comment 5 Fedora Update System 2018-05-22 15:03:41 UTC

vte291-0.50.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1a88439459

Comment 6 Fedora Update System 2018-05-22 19:38:32 UTC

gnome-terminal-3.28.2-1.fc28, vte291-0.52.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f1454efdd4

Comment 7 Fedora Update System 2018-05-23 15:41:46 UTC

gnome-terminal-3.28.2-1.fc28, vte291-0.52.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2018-05-25 15:44:53 UTC

vte291-0.50.4-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.