Bug 1581150

+++ This bug was initially created as a clone of Bug #1578955 +++

Description of problem:
With certain configurations 'pcs config' is totally failing
claiming that xml doesn't conform to schema.

Version-Release number of selected component (if applicable):
pcs-0.9.162-5.el7

How reproducible:
100%

Steps to Reproduce:

This example was walked through on rhel-8.0 with pcs-0.9.164-1.el7
but should work with anything that is mangled via upgrade as
described in /usr/share/pacemaker/upgrade-*.xsl.

1. Setup a cluster with a stonith-resource named Fencing (e.g. the test-config cti would setup)

2. Add an attribute that would be altered via a cib upgrade

cibadmin --create --xml-text '<configuration> <resources> <primitive id="Fencing"> <instance_attributes id="Fencing-params"> <nvpair id="Fencing-pcmk_arg_map" name="pcmk_arg_map" value="domain:uname"/> </instance_attributes> </primitive> </resources> </configuration>'

3. issue 'pcs config'

Actual results:
  [root@node2 ~]# pcs config
  Cluster Name: sbd-rhel8
  Error: cannot load cluster status, xml does not conform to the schema

Expected results:
output of cluster-config


Additional info:

The misbehaviour is due to pcs taking both stderr & stdout from crm_mon making this mixture not conform with even the basic-structure of xml.

Suggested fix:
diff --git a/pcs/utils.py b/pcs/utils.py
index 1648a62..b928629 100644
--- a/pcs/utils.py
+++ b/pcs/utils.py
@@ -1947,7 +1947,8 @@ def getClusterState():
 
 # DEPRECATED, please use lib.pacemaker.live.get_cluster_status_xml in new code
 def getClusterStateXml():
-    xml, returncode = run(["crm_mon", "--one-shot", "--as-xml", "--inactive"])
+    xml, returncode = run(["crm_mon", "--one-shot", "--as-xml", "--inactive"],
+                          ignore_stderr=True)
     if returncode != 0:
         err("error running crm_mon, is pacemaker running?")
     return xml

Command to revert the addition of the attribute:
cibadmin --delete --xml-text '<nvpair id="Fencing-pcmk_arg_map"   name="pcmk_arg_map" />'

Check stderr output of crm_mon besides xml to be parsed by pcs:
  [root@node2 ~]# crm_mon --one-shot --as-xml --inactive >/dev/null
  Resource instance_attributes: Fencing-pcmk_arg_map: dropping pcmk_arg_map

Be aware that with pacemaker-2.0.x we have an increase in the major-version.
Coming with that we have substantial changes in the cluster-config.
To be able to cope with that situation a lot more stuff is mangled via /usr/share/pacemaker/upgrade-*.xsl.
So be prepared to meet configs creating these stderr outputs a lot more often.
When it is not possible to do the mangling automatically stderr will give hints how to adapt the cib manually.
Thus it might be considered to not just ignore those outputs on stderr but as well to show them in one or the other way.
Afaik there is no easy string-identification at the moment telling if manual intervention would be necessary.