Bug 1581337

Summary: Add config for disabling creation of PING type HMs
Product: Red Hat OpenStack Reporter: Nir Magnezi <nmagnezi>
Component: openstack-octaviaAssignee: Nir Magnezi <nmagnezi>
Status: CLOSED ERRATA QA Contact: Bruna Bonguardo <bbonguar>
Severity: high Docs Contact:
Priority: high    
Version: 13.0 (Queens)CC: bbonguar, cgoncalves, ihrachys, lpeer, majopela, mgeary, shdunne, slinaber, takito
Target Milestone: z7Keywords: TestOnly, Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-octavia-2.0.4-3.el7ost Doc Type: Known Issue
Doc Text:
HAProxy, used for network load balancing, must be version 1.6 or higher to correctly support the PING type health monitor. The version of HAProxy included with Red Hat OpenStack Platform 13 is an older version than 1.6 that uses TCP connect instead when you configure the PING type health monitor.
 Story Points: ---
Clone Of:
: 1644883 1700359 1798064 (view as bug list) Environment:
Last Closed: 2019-07-10 13:01:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1644883, 1698860    
Bug Blocks: 1700359, 1798064    
Attachments:
Description Flags
tests.log none

Description Nir Magnezi 2018-05-22 14:28:54 UTC 
Description of problem:
=======================
In OSP13, we ship an old version of haproxy who does not support external monitors. Thus, ping type health monitors does not actually work (it uses tcp connect instead).

We should block ping type HMs by default and produce a warning to the user.

Most of this is covered by: https://review.openstack.org/#/c/528439/
Comment 13 Nir Magnezi 2019-05-01 12:40:13 UTC 
Created attachment 1560745 [details]
tests.log

Testing allow_ping_health_monitors = False/True
Comment 14 Nir Magnezi 2019-05-01 12:41:09 UTC 
Hi Bruna,

Thank you for looking into this.
The msg you have posted is indeed the expected result when  allow_ping_health_monitors = False (default).

I connected to your setup and tested for both True/False values of allow_ping_health_monitors, both looked okay (check the attached log file in comment 13). 

See that when we don't allow ping HMs (default), we block the creation of it and return the msg to the user, and when it is set to True we do allow the creation but produce the warning.

Please let me know if you have additional questions.

Nir
Comment 15 Nir Magnezi 2019-05-02 06:37:39 UTC 
Bruna,

Per your question on IRC, please restart the octavia-api container for config changes (allow_ping_health_monitors) to be applied.
Comment 19 errata-xmlrpc 2019-07-10 13:01:59 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1744