Bug 158159
| Summary: | 2 * missing return statements | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> |
| Component: | yelp | Assignee: | Ray Strode [halfline] <rstrode> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-08-31 18:47:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
These problems don't seem to be an issue anymore. Closing...
>These problems don't seem to be an issue anymore.
Seek clarification.
Does this mean that you have checked the source code manually,
and can verify that these two problems no longer exist ?
Yes. Those functions don't exist anymore as far as I can see. |
Description of problem: I just tried to compile package yelp-2.9.3-6 from Redhat Fedora Core development tree with the most excellent Intel C compiler. The compiler said 1. yelp-gecko-utils.cpp(211): warning #1011: missing return statement at end of non-void function "yelp_gecko_copy_selection" The source code is extern "C" gboolean yelp_gecko_copy_selection (GtkMozEmbed *embed) { nsCOMPtr<nsIWebBrowser> webBrowser; gtk_moz_embed_get_nsIWebBrowser (embed, getter_AddRefs(webBrowser)); nsCOMPtr<nsIClipboardCommands> clip (do_GetInterface(webBrowser)); NS_ENSURE_TRUE (clip, NS_ERROR_FAILURE); clip->CopySelection(); } Suggest add return statement to the end of the routine. 2. yelp-gecko-utils.cpp(224): warning #1011: missing return statement at end of non-void function "yelp_gecko_select_all" Same thing again. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: