Bug 1581880

Summary: Review Request: nodejs-ts-node - TypeScript execution environment and REPL for node
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mattia.verga, package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-11 07:54:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1581835, 1581839    
Bug Blocks: 201449    

Description Jared Smith 2018-05-23 20:23:16 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-ts-node/nodejs-ts-node.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-ts-node/nodejs-ts-node-6.0.3-1.fc29.src.rpm
Description: TypeScript execution environment and REPL for node
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-05-23 22:48:52 UTC
Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.I6V0or
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ NODE_ENV=test
+ /usr/bin/mocha 'dist/**/*.spec.js' -R spec --bail
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'chai'

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.PT8Zpw
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ NODE_ENV=test
+ /usr/bin/mocha 'dist/**/*.spec.js' -R spec --bail
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'semver'

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.ZvjsEE
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ NODE_ENV=test
+ /usr/bin/mocha 'dist/**/*.spec.js' -R spec --bail
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'typescript'

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.2RaXje
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ NODE_ENV=test
+ /usr/bin/mocha 'dist/**/*.spec.js' -R spec --bail
BUILDSTDERR: module.js:549
BUILDSTDERR:     throw err;
BUILDSTDERR:     ^
BUILDSTDERR: Error: Cannot find module 'proxyquire'

Add the PR for tests:

%if 0%{?enable_tests}
BuildRequires:	mocha
BuildRequires:	npm(chai)
BuildRequires:	npm(semver)
BuildRequires:	npm(typescript)
BuildRequires:	npm(proxyquire)
%endif

Install then fails:

DEBUG util.py:485:  Last metadata expiration check: 0:00:00 ago on jeu. 24 mai 2018 00:44:34 CEST.
DEBUG util.py:483:  BUILDSTDERR: Error: 
DEBUG util.py:483:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:483:  BUILDSTDERR:   - nothing provides (npm(chalk) >= 2.3.0 with npm(chalk) < 3) needed by nodejs-ts-node-6.0.3-1.fc29.noarch

It needs to be updated to the latest version: https://src.fedoraproject.org/rpms/nodejs-chalk

Comment 3 Robert-André Mauchin 🐧 2018-05-24 15:06:12 UTC
Package approved but don't forget to upgrade npm(chalk).

Comment 4 Jared Smith 2018-05-24 19:50:27 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6756.

Comment 5 Gwyn Ciesla 2018-05-24 23:15:40 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-ts-node

Comment 6 Mattia Verga 2020-06-02 14:55:29 UTC
This package was approved many years ago, but never imported. Are you still interested in getting it into Fedora repositories?

Comment 7 Mattia Verga 2020-07-11 07:54:04 UTC
No reply, closing as DEADREVIEW and retiring package from pagure.