Bug 1582068

Summary:	ctime: Rename and unlink does not update ctime
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	posix	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.1	CC:	bugs, nchilaka
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-v4.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1580020	Environment:
Last Closed:	2018-06-20 18:07:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1580020
Bug Blocks:

Description Kotresh HR 2018-05-24 06:47:19 UTC

+++ This bug was initially created as a clone of Bug #1580020 +++

Description of problem:
Successful rename and unlink (if link count > 1) is not updating ctime.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Alwasy

Steps to Reproduce:
1. Create gluster volume and mount 
2. Create file, stat file to record ctime. Rename file to rn_file, stat rn_file to check ctime. Ctime should be changed
3. Create file, create hard link named 'hl_file', stat file to record ctime.
   unlink hl_file, stat file to check ctime. ctime should be changed

Actual results:
Ctime doesn't change

Expected results:
Ctime should be changed.

Additional info:

--- Additional comment from Kotresh HR on 2018-05-19 03:42:44 EDT ---

Forgot to mention,

This is with ctime feature enabled, i.e.,

gluster vol set utime on
gluster vol set ctime on

--- Additional comment from Worker Ant on 2018-05-19 04:09:25 EDT ---

REVIEW: https://review.gluster.org/20039 (features/posix: Fix updating ctime in rename and unlink) posted (#1) for review on master by Kotresh HR

--- Additional comment from Worker Ant on 2018-05-24 01:49:53 EDT ---

COMMIT: https://review.gluster.org/20039 committed in master by "Kotresh HR" <khiremat> with a commit message- ctime: Fix updating ctime in rename and unlink

1. Successful rename was not updating ctime.
   Fixed the same.
2. Successful unlink when link count is more than 1
   was not updating ctime. Fixed the same.
3. Copy ctime and flags during frame copy.

fixes: bz#1580020
Change-Id: Ied47275a36aea60254b2add7a59128a9c83b3645
Signed-off-by: Kotresh HR <khiremat>

Comment 1 Worker Ant 2018-05-24 07:43:57 UTC

REVIEW: https://review.gluster.org/20077 (ctime: Fix updating ctime in rename and unlink) posted (#1) for review on release-4.1 by Kotresh HR

Comment 2 Worker Ant 2018-05-24 19:13:14 UTC

COMMIT: https://review.gluster.org/20077 committed in release-4.1 by "Kotresh HR" <khiremat> with a commit message- ctime: Fix updating ctime in rename and unlink

1. Successful rename was not updating ctime.
   Fixed the same.
2. Successful unlink when link count is more than 1
   was not updating ctime. Fixed the same.
3. Copy ctime and flags during frame copy.

Backport of:
 > Patch: https://review.gluster.org/20039
 > BUG: 1580020
 > Change-Id: Ied47275a36aea60254b2add7a59128a9c83b3645

fixes: bz#1582068
Change-Id: Ied47275a36aea60254b2add7a59128a9c83b3645
Signed-off-by: Kotresh HR <khiremat>

Comment 3 Shyamsundar 2018-06-20 18:07:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report.

glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html
[2] https://www.gluster.org/pipermail/gluster-users/