Bug 1582469

Summary:	Review Request: plasma-browser-integration - components necessary to integrate browsers into the Plasma Desktop
Product:	[Fedora] Fedora	Reporter:	Martin Kyral <mkyral>
Component:	Package Review	Assignee:	Jan Grulich <jgrulich>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, jgrulich, laurent.rineau__fedora, package-review, rdieter
Target Milestone:	---	Flags:	jgrulich: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-01-02 10:15:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997

Description Martin Kyral 2018-05-25 10:24:46 UTC

Description of problem:
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-browser-integration.git/tree/plasma-browser-integration.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-rawhide-x86_64/00758801-plasma-browser-integration/plasma-browser-integration-5.12.90-1.fc29.src.rpm
Description: plasma-browser-integration coupled with a browser plugin provides integration of the browser in the desktop.
Fedora Account System Username: mkyral

Version-Release number of selected component (if applicable):
5.12.90


Additional info:

Comment 1 Jan Grulich 2018-05-25 10:54:53 UTC

1) Naming: ok
2) License: Ok, some files are GPLv2+ and some GPLv3
3) URL: ok
4) Scriptlets: ok, not used and not needed
5) Files section: ok, license file installed

Minor thing, the patch is not upstreamable, I tried to propose it to upstream, but this way it would break installation for Debian/Ubuntu.

Comment 2 Martin Kyral 2018-05-25 11:19:09 UTC

Moved the patch to downstream patches:

http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-browser-integration.git/commit/?id=c52348c3bcae5b80a2cc1c44bb7c89a26dae6621

Comment 3 Kevin Kofler 2018-06-04 18:13:22 UTC

Shouldn't the %description mention the browsers that are actually supported by this thing? Because there are definitely browsers out there that it won't work with.

Comment 4 Gwyn Ciesla 2018-06-08 12:12:07 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-browser-integration