Bug 1582955

Summary: qt5-qtwebengine FTBFS
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: qt5-qtwebengineAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: kevin
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-29 19:37:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1584240    

Description Rex Dieter 2018-05-27 22:53:05 UTC
Last couple of qt5-qtwebengine builds have failed,

https://koji.fedoraproject.org/koji/buildinfo?buildID=1077918
https://koji.fedoraproject.org/koji/buildinfo?buildID=1085513

Appears to be i686-specific

Comment 1 Kevin Kofler 2018-05-27 23:09:39 UTC
Known, this is needed also in the Fedora package:
https://pkgs.rpmfusion.org/cgit/free/qt5-qtwebengine-freeworld.git/commit/?id=28132e7191db565999c64ca9cb60722a3e1f4825

Comment 2 Rex Dieter 2018-05-28 12:39:55 UTC
Thanks, pulled that in.

Comment 3 Rex Dieter 2018-05-28 14:39:28 UTC
Boo, apparently that is insufficient, build failed.  This one does appear to be 5.11.x related,

/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/webpage.cpp: In member function 'virtual bool WebPage::certificateError(const QWebEngineCertificateE
rror&)':
/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/webpage.cpp:77:39: error: invalid use of incomplete type 'class QStyle'
         QIcon icon(mainWindow->style()->standardIcon(QStyle::SP_MessageBoxWarning, 0, mainWindow));
                                       ^~
In file included from /usr/include/qt5/QtWidgets/qmainwindow.h:44,
                 from /usr/include/qt5/QtWidgets/QMainWindow:1,
                 from /builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/browserwindow.h:54,
                 from /builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/webpage.cpp:51:
/usr/include/qt5/QtWidgets/qwidget.h:67:7: note: forward declaration of 'class QStyle'
 class QStyle;
       ^~~~~~
/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/webpage.cpp:77:62: error: incomplete type 'QStyle' used in nested name specifier
         QIcon icon(mainWindow->style()->standardIcon(QStyle::SP_MessageBoxWarning, 0, mainWindow));
                                                              ^~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/webpage.cpp: In member function 'void WebPage::handleAuthenticationRequired(const QUrl&, QAuthenticator*)':
/builddir/build/BUILD/qtwebengine-everywhere-src-5.10.1/examples/webenginewidgets/simplebrowser/webpage.cpp:99:35: error: invalid use of incomplete type 'class QStyle'
     QIcon icon(mainWindow->style()->standardIcon(QStyle::SP_MessageBoxQuestion, 0, mainWindow));

...


Full logs,
https://koji.fedoraproject.org/koji/taskinfo?taskID=27257724

Comment 4 Kevin Kofler 2018-05-28 16:07:30 UTC
Yeah, this is one of the missing #include issues with Qt 5.11.

Comment 5 Rex Dieter 2018-05-29 19:37:25 UTC
Pulled in one more upstream commit to fix it,
http://code.qt.io/cgit/qt/qtbase.git/commit/src/testlib/qtestmouse.h?id=75e583b3fcbdbbb999633eb5f2267720dd695cfa