Bug 1583159
| Summary: | Sample service file vncserver@.service is out of date with systemd changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Korsunsky <a.korsunsky> | ||||||
| Component: | tigervnc | Assignee: | Jan Grulich <jgrulich> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 28 | CC: | fedora, jgrulich, twaugh, vonsch | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | tigervnc-1.8.0-10.fc27 tigervnc-1.8.0-10.fc28 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-06-16 19:32:44 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Alexander Korsunsky
2018-05-28 11:12:53 UTC
Created attachment 1443332 [details]
Proposed Unit file for the Tiger VNC service
For that matter, here's our unit file for a VNC server that runs as a "service":
* Start and Stop are properly detected
* Logging out of the server causes the service to be marked as stop
* 15 seconds after logout, the service is restart to permit a new login
Created attachment 1450824 [details]
Proposed vncserver.service file
What about this one?
Few questions regarding your version. Why do you use "type=notify" under [Service] section, I think it should stay on "type=forking". I see there is problem when using runuser, it was there as Gnome had problems to fully start without it. I was suggested once to use e.g. "PAMName=login" instead, but now it seems that neither of them is needed.
This one looks good too. > Why do you use "type=notify" under [Service] section, I think it should stay on "type=forking". You are right, forking is probably better. The reason I had notify in there is that I wanted to avoid the whole PIDFile business due to Bug 1418463 and let the desktop sessions communicate their status via sd_notify. However, that requires NotifyAccess=all because it's not vncserver who sends the sd_notify, but the GNOME/XFCE session. This may or may not be awkward for security. > I was suggested once to use e.g. "PAMName=login" instead, but now it seems that neither of them is needed. It certainly seems so. If the SELinux policy is amended to allow systemd to access .vnc directories, the unit file works pretty well. tigervnc-1.8.0-10.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f67d10ae9e tigervnc-1.8.0-10.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-817f36c368 tigervnc-1.8.0-10.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f67d10ae9e tigervnc-1.8.0-10.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-817f36c368 tigervnc-1.8.0-10.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. tigervnc-1.8.0-10.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |