Bug 1583626
| Summary: | python-twisted FTBFS with Python 3.7 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> | ||||||
| Component: | python-twisted | Assignee: | Thomas Vander Stichele <thomas> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | thomas | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-06-13 14:14:51 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1565020 | ||||||||
| Attachments: |
|
||||||||
This has not yet been fixed upstream: https://github.com/twisted/twisted/blob/2e7b403c03e9b9b891a5eb36297e494f541d5d6a/src/twisted/conch/manhole.py#L154 There might be other problems: https://github.com/twisted/twisted/pull/1018 Created attachment 1445370 [details]
root.log from copr
Thomas? See proposed upstream fix: https://github.com/twisted/twisted/pull/966 FYI: 3.7.0c1 is expected in 3 days (2018-06-11, [1]). I'd like to start building stuff in a side tag soon after that. This blocks the "packager stack", hence a bit critical. Thomas, could you please respond? [1] https://www.python.org/dev/peps/pep-0537/ I'm trying to backport https://github.com/twisted/twisted/pull/966 to see if that helps. This package does not run tests, so I will simply try to rebuild the dependent packages to verify if "works". txzmq:
+ nosetests-3.7
...
Ran 36 tests in 3.346s
python-moksha-hub:
+ /usr/bin/python3 setup.py test
...
Ran 58 tests in 60.315s
Patch ready at https://src.fedoraproject.org/rpms/python-twisted/pull-request/5 Still waiting for "important" packages to build. + py.test-3 fedmsg ============= 222 passed, 102 skipped, 1 warnings in 14.80 seconds ============= I think we are good in here. Pushed the dirty patch. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |
Created attachment 1445368 [details] build.log from copr Description of problem: python-twisted FTBFS with Python 3.7 bacuse it uses async (now a keyword) as a function parameter name. Bytecompiling .py files below /builddir/build/BUILDROOT/python-twisted-16.4.1-9.fc29.x86_64/usr/lib64/python3.7 using /usr/bin/python3.7 *** Error compiling '/builddir/build/BUILDROOT/python-twisted-16.4.1-9.fc29.x86_64/usr/lib64/python3.7/site-packages/twisted/conch/manhole.py'... File "/usr/lib64/python3.7/manhole.py", line 133 def write(self, data, async=False): ^ SyntaxError: invalid syntax Version-Release number of selected component (if applicable): 16.4.1-9.fc29 This is blocking other packages. Build logs attached.