Bug 1583678
| Summary: | python-markdown FTBFS with Python 3.7 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> | ||||||
| Component: | python-markdown | Assignee: | Thomas Moschny <thomas.moschny> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ncoghlan, thomas.moschny | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 2.6.11-2.fc29 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-06-04 09:13:43 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1565020 | ||||||||
| Attachments: |
|
||||||||
Created attachment 1445381 [details]
root.log from copr
So upstream tests pass, and I didn't see any noticable difference except that upstream runs test a bit differently and voilà https://src.fedoraproject.org/rpms/python-markdown/pull-request/2 That fix working technically means you've found a unittest bug where the discover subcommand isn't correctly turning on reporting of deprecation warnings :) And it should? Let's report this then. It reports the warning, it just doesn't turn it into errors.
$ python3.7 -m unittest discover -v
test_foo (test_reproducer.TestFoo) ... /home/churchyard/tmp/discover_bug/test_reproducer.py:6: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Mapping
ok
----------------------------------------------------------------------
Ran 1 test in 0.000s
OK
With -Werror it does:
$ python3.7 -Werror -m unittest discover -v
test_foo (test_reproducer.TestFoo) ... ERROR
======================================================================
ERROR: test_foo (test_reproducer.TestFoo)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/churchyard/tmp/discover_bug/test_reproducer.py", line 6, in test_foo
from collections import Mapping
File "<frozen importlib._bootstrap>", line 1032, in _handle_fromlist
File "/usr/lib64/python3.7/collections/__init__.py", line 52, in __getattr__
DeprecationWarning, stacklevel=2)
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
----------------------------------------------------------------------
Ran 1 test in 0.007s
FAILED (errors=1)
This is not desired behavior?
As python-markdown (in the released version) still uses nose for the tests, the workaround would imho not execute the same set of tests. Therefore, I add a different fix (see https://src.fedoraproject.org/rpms/python-markdown/c/93312f7d), please test. A new build dependency make this being blocked by bz1577396. Why it was added? Sorry, maybe it got not. Let me recheck. Ok, the gdb problem was unrelated indeed, I prematurely jumped to conclusions. It builds now. Thank you. |
Created attachment 1445380 [details] build.log from copr Description of problem: python-markdown FTBFS with Python 3.7 ERROR: Failure: DeprecationWarning (Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working) Version-Release number of selected component (if applicable): 2.6.11-1.fc29 Logs attached.