Bug 1583681

Summary:	lsmcli iscsi-chap should fail if given just user without pass or vice versa
Product:	Red Hat Enterprise Linux 7	Reporter:	Jakub Krysl <jkrysl>
Component:	libstoragemgmt	Assignee:	Tony Asleson <tasleson>
Status:	CLOSED ERRATA	QA Contact:	Jakub Krysl <jkrysl>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.6	CC:	tasleson
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-06 12:40:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jakub Krysl 2018-05-29 13:25:06 UTC

Description of problem:
When usin command 'lsmcli iscsi-chap' user has the ability to specify inbound/outbound username and password. There is no check if these are used in pairs, as for example in-pass does not make sense if no in-user is specified. So  this passes:
# lsmcli -u "sim://" iscsi-chap --init='iqn.1986-05.com.example:lsm-chap' --in-pass='in_pass'

Version-Release number of selected component (if applicable):
libstoragemgmt-1.6.2-1

How reproducible:
100%

Steps to Reproduce:
1.lsmcli -u "sim://" iscsi-chap --init='iqn.1986-05.com.example:lsm-chap' --in-pass='in_pass'
2. echo $?

Actual results:
1. 
2. 0

Expected results:
1. argparse error, use 'in-user' when using 'in-pass'
2. 2

Additional info:
The exact same behaviour is reproducible with ontap plugin. Checking NetApp itself with 'iscsi security show', libstoragemgmt created this:
init: iqn.1994-05.com.redhat:lsm-chap auth: None

Comment 2 Jakub Krysl 2018-05-29 15:00:57 UTC

Trying manually on NetApp produces this error:
> iscsi security add -i iqn.1994-05.com.redhat:lsm-chap -s CHAP -p test
iscsi security add: missing CHAP inname
Usage: iscsi security add -i <initiator> -s [CHAP|deny|none] [-f RADIUS | -p <inpassword> -n <inname>] [-o <outpassword> -m <outname>]

When using just name and no password, NetApp asks for it.

Comment 5 Jakub Krysl 2019-01-28 15:29:56 UTC

libstoragemgmt-1.7.2-1.el7.x86_64

lsmcli -u "sim://" iscsi-chap --init='iqn.1986-05.com.example:lsm-chap-x86-64' --in-user='redhat_in_user-x86-64''...                                                    
lsmcli: error: --in-user requires --in-pass
lsmcli -u "sim://" iscsi-chap --init='iqn.1986-05.com.example:lsm-chap-x86-64' --in-pass='redhat_in_pass''...                                                    
lsmcli: error: --in-pass requires --in-user
lsmcli -u "sim://" iscsi-chap --init='iqn.1986-05.com.example:lsm-chap-x86-64' --out-user='redhat_out_user-x86-64''...                                                    
lsmcli: error: --out-user requires --out-pass
lsmcli -u "sim://" iscsi-chap --init='iqn.1986-05.com.example:lsm-chap-x86-64' --out-pass='redhat_out_pass''...                                                    
lsmcli: error: --out-pass requires --out-user

Comment 7 errata-xmlrpc 2019-08-06 12:40:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2064