Bug 1583688

Summary: python3-py3dns FTBFS on python 3.7
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python3-py3dnsAssignee: Fedora Infrastructure SIG <infra-sig>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: infra-sig, kevin, rbean
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-06-09 20:32:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1565020    
Attachments:
Description Flags
build.log from copr
none
root.log from copr none

Description Miro Hrončok 2018-05-29 13:39:25 UTC
Created attachment 1445383 [details]
build.log from copr

Description of problem:

+ /usr/bin/python3 setup.py build
Traceback (most recent call last):
  File "setup.py", line 7, in <module>
    import DNS
  File "/builddir/build/BUILD/py3dns-3.1.1/DNS/__init__.py", line 27, in <module>
    from .Base import DnsRequest
  File "/builddir/build/BUILD/py3dns-3.1.1/DNS/Base.py", line 100
    self.async=None
             ^
SyntaxError: invalid syntax


Version-Release number of selected component (if applicable): 3.1.1-5.fc29

Logs attached.

Comment 1 Miro Hrončok 2018-05-29 13:39:59 UTC
Created attachment 1445384 [details]
root.log from copr

Comment 2 Miro Hrončok 2018-05-29 13:40:51 UTC
async and await are keywords in python 3.7 and cannot be used as atribute names.

Comment 3 Miro Hrončok 2018-06-04 13:09:23 UTC
Infra people, please respond.

Comment 4 Kevin Fenzi 2018-06-04 17:48:19 UTC
ok, so the fix here is just to change async to some other name?

Comment 5 Miro Hrončok 2018-06-04 23:29:33 UTC
Yes. Preferably in upstream.

Comment 6 Miro Hrončok 2018-06-08 10:42:19 UTC
FYI: 3.7.0c1 is expected in 3 days (2018-06-11, [1]). I'd like to start building stuff in a side tag soon after that.

This blocks the "packager stack", hence a bit critical.


[1] https://www.python.org/dev/peps/pep-0537/

Comment 7 Kevin Fenzi 2018-06-09 20:32:46 UTC
I've added a quick and dirty patch to change the name and pushed and built it in rawhide. 

I filed https://bugs.launchpad.net/py3dns/+bug/1776027 upstream with the issue and a patch (I have no idea how responsive upstream is). 

Let me know if that doesn't solve the issue...

Comment 8 Miro Hrončok 2018-06-10 18:36:07 UTC
https://copr.fedorainfracloud.org/coprs/g/python/python3.7/build/765277/ succeeded

Thank you.