Bug 1583694

Summary: Dynamic Drop Down Dialog not working with Automate Expression Method
Product: Red Hat CloudForms Management Engine Reporter: myoder
Component: AutomateAssignee: Tina Fitzgerald <tfitzger>
Status: CLOSED NOTABUG QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, duhlmann, mkanoor, nansari, obarenbo, smallamp, sshveta, tfitzger
Target Milestone: GA   
Target Release: 5.9.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-05 14:15:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1595269    
Attachments:
Description Flags
domain
none
dilaog
none
No dynamic method defined for dropdown
none
The expression Templates in My Ldap group is empty
none
Values available none

Description myoder 2018-05-29 13:48:42 UTC 
Description of problem:

Created a dynamic drop down element that is populated by an automate expression method.  When using this dialog (for a service or button) the drop down element is populated with the correct attributes, however I can not select any of them to submit.


This does not seem to be a problem with radio button elements, so far only with drop down elements.


FWIW the expression object for the autoamte expression method is:

  ManageIQ::Providers::InfraManager::Template

And the expression is:

  Template:In My LDAP Group?='true'


Version-Release number of selected component (if applicable):
CFME 5.9.2

How reproducible:
always

Steps to Reproduce:
1. Create a method that is based off of an expression
2. Create a dialog with a dynamic drop down element that points to the custom expression automate method
3. Create a service that uses the dialog created in step 2.
4. Order the service and see that the drop down element has choices, however one can not select any of them.

Actual results:
Can not select a value in the drop down element.

Expected results:
Should be able to select a value from the drop down element.

Additional info:
Reproduced on 10.13.145.83 admin:smartvm

Created a button for VMs that has both drop down and radio buttons.  The button goup is Test and the button is Expression Method.

Also the catalog RHEV => Template that shows the issue too.
Comment 3 Sudhir Mallamprabhakara 2018-05-30 13:52:40 UTC 
Niyaz,

Can you check this scenario against latest master and update the bz with your comments.

- Sudhir
Comment 5 drew uhlmann 2018-05-31 13:05:58 UTC 
The appliance listed is 5.9.2.4 which has a known patternfly issue with dropdowns of this sort. Since I can do a jquery refresh on the field and see that it has the right value. We believe that this is fixed by the changes that Erik made recently, the one here: https://github.com/ManageIQ/ui-components/pull/295. This isn't a backend issue.
Comment 6 Tina Fitzgerald 2018-05-31 13:08:49 UTC 
Per comment 5, We think issue has been fixed with latest PRs. Waiting for QE to validate.
Comment 7 Shveta 2018-06-01 18:51:54 UTC 
@Tina : This is not fixed on latest upstream . 
We should be verifying on next upstream build then I suppose ?
Comment 8 Shveta 2018-06-01 18:57:44 UTC 
Created attachment 1446788 [details]
domain

attached Domain for future testing
Comment 9 Shveta 2018-06-01 18:58:09 UTC 
Created attachment 1446789 [details]
dilaog

Dialog used for testing
Comment 10 Sudhir Mallamprabhakara 2018-06-01 19:52:30 UTC 
@Tina - Per https://bugzilla.redhat.com/show_bug.cgi?id=1583694#c4, QE used Upstream build master.20180530013347_bee8c3b to validate this BZ.

I have confirmed with Satoe that this upstream build had pr 295. So, maybe the fix hasn't fixed the issue.. maybe??
Comment 11 mkanoor 2018-06-01 20:06:26 UTC 
I looked at the QE database and the dropdown doesn't have an entry point set.
Screenshot attached.
Comment 12 mkanoor 2018-06-01 20:07:34 UTC 
Created attachment 1446794 [details]
No dynamic method defined for dropdown
Comment 13 mkanoor 2018-06-01 20:35:31 UTC 
I apologize, my mistake, Spoke too soon, I see the expression method from Yoders domain.
That expression method is returning an empty list.
I have added an inline method and an expression method which returns a single VM.
That seems to work. I tested with both an inline method as well as an expression method.

Please re-verify.
Comment 14 mkanoor 2018-06-01 20:43:36 UTC 
The expression Templates in my LDAP Group is empty.
Attached is a screenshot of that.
Comment 15 mkanoor 2018-06-01 20:44:40 UTC 
Created attachment 1446808 [details]
The expression Templates in My Ldap group is empty
Comment 16 mkanoor 2018-06-01 21:03:52 UTC 
I spoke to Yoder about this, in order to use his expression you need to configure LDAP and have a Template be owned by the LDAP group.
In order to create a similar filter, I have added a expression method Vm or Templates owned by me.
So when you login in as "admin" you should see a single template called "damnSmallUnix" in the dropdown.
Comment 17 Tina Fitzgerald 2018-06-01 21:15:03 UTC 
Hi Sudhir,

Per comment 16, this is working properly, depending on what expression is used.
Do you want to validate that before I close this as not a bug?

Thanks,
Tina
Comment 18 Shveta 2018-06-04 17:01:45 UTC 
Niyaz please verify this again based on new comments.
Comment 19 Niyaz Akhtar Ansari 2018-06-05 17:26:46 UTC 
Created attachment 1447961 [details]
Values available

I have followed the steps based on new comments on upstream master.20180530202952_f827149.
It works fine.I can see and select the values.
Comment 20 Tina Fitzgerald 2018-07-03 20:21:55 UTC 
Hi Shveta,

Can you test this against the latest 5.9 build?

Thanks,
Tina
Comment 21 Niyaz Akhtar Ansari 2018-07-04 06:46:03 UTC 
Hi Tina, It works fine in latest 5.9.3.4